Re: linux-next: build failure after merge of the mfd tree

Lee Jones
2012-05-21T10:28:23Z

> Since there's no dependencies which would stop it being selected
> anything like allyesconfig or randconfig might enable it. In general
> it's normal to allow this in order to make it easier to build test
> things like subsystem wide changes.

Ah, I see. In which case Stephen was correct in that it's an issue with
Kconfig logic (but not an issue with the patch alluded to). I'm going to
have to pass this one over to Linus (CC'ed), as it's his train-set and I
don't want to do the wrong thing.

Linus,

When CONFIG_AB8500_CORE is set, building ab8500-core.c and
!(CONFIG_UX500_SOC_DB8500 | CONFIG_MFD_DB8500_PRCMU), both
db8500-prcmu.h and dbx500-prcmu.h take it upon themselves to _both_
create 'return 0' inline functions for the following:

prcmu_abb_read()
prcmu_abb_write()
prcmu_config_clkout()
prcmu_ac_wake_req()
prcmu_ac_sleep_req()

I think we need a Kconfig rule to prevent this from happening, but I'm
not sure what the correct logic would be. The other option would be to
explicitly include db8500-prcmu.h instead of dbx500-prcmu.h in
ab0500-core.c (which in turn includes db8500-prcmu.h (and used to
include db5500-prcmu.h)), but this seems wrong to me.

As you have a clearer insight to these things would you care to take
this on?

Kind regards,
Lee

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog