Re: linux-next: build failure after merge of the mfd tree

Rob Herring
2013-04-09T16:50:30Z

On Tue, Apr 9, 2013 at 11:12 AM, Samuel Ortiz <sameo@linux.intel.com> wrote:
> Hi Alexander,
>
> On Tue, Apr 09, 2013 at 07:47:40PM +0400, Alexander Shiyan wrote:
>> > On Mon, Apr 08, 2013 at 08:27:49PM +0400, Alexander Shiyan wrote:

[...]

>> From 3296415f29818a430bad12c92dc65cd81e4d133f Mon Sep 17 00:00:00 2001
>> From: Alexander Shiyan <shc_work@mail.ru>
>> Date: Tue, 9 Apr 2013 19:41:27 +0400
>> Subject: [PATCH] of: add stub of_get_parent for non-OF builds
>>
>> Fixes build error on x86_64 allmodconfig, introduced by commit
>> 5ab3a89a741f ("mfd: syscon: Add non-DT support").
>>
>> drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
>> drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
>> ---
>> include/linux/of.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index a0f1292..9f5923f 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -353,6 +353,11 @@ static inline struct device_node *of_find_node_by_name(struct device_node *from,
>> return NULL;
>> }
>>
>> +static inline struct device_node *of_get_parent(const struct device_node *node)
>> +{
>> + return NULL;
>> +}
>> +
> That looks like a proper fix, but I'd like to get Grant or/and Rob's ACK for
> it before merging it. Please look at MAINTAINERS and cc them on this thread.

Acked-by: Rob Herring <rob.herring@calxeda.com>