From: Michael Neuling <mikey@neuling.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Michal Marek <mmarek@suse.cz>
Subject: [PATCH] serial: fix Kconfig for Freescale 16550
Date: Tue, 13 Dec 2011 11:31:03 +1100 [thread overview]
Message-ID: <7963.1323736263@neuling.org> (raw)
next-20111212 breaks with linking a pmac32_defconfig with:
drivers/built-in.o: In function `fsl8250_handle_irq':
(.text+0x7ba74): undefined reference to `serial8250_modem_status'
drivers/built-in.o: In function `fsl8250_handle_irq':
(.text+0x7baa4): undefined reference to `serial8250_tx_chars'
drivers/built-in.o: In function `fsl8250_handle_irq':
(.text+0x7bab4): undefined reference to `serial8250_rx_chars'
Caused by:
9deaa53 serial: add irq handler for Freescale 16550 errata.
pmac32_defconfig results in SERIAL_8250_FSL=y but SERIAL_8250=m so
8250_fsl.c doesn't link properly.
This explicitly makes SERIAL_8250_FSL depends on SERIAL_8250=y.
Signed-off-by: Michael Neuling <mikey@neuling.org>
---
I'm not sure this is the right fix as it seems like a Kconfig bug.
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a1d55c3..c9046de 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -99,7 +99,7 @@ config SERIAL_8250_PNP
config SERIAL_8250_FSL
bool
- depends on SERIAL_8250 && PPC
+ depends on SERIAL_8250=y && PPC
default PPC
config SERIAL_8250_HP300
next reply other threads:[~2011-12-13 0:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 0:31 Michael Neuling [this message]
2011-12-13 0:54 ` [PATCH] serial: fix Kconfig for Freescale 16550 Greg KH
2011-12-13 1:53 ` Michael Neuling
2011-12-13 2:47 ` Paul Gortmaker
2011-12-13 2:58 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7963.1323736263@neuling.org \
--to=mikey@neuling.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).