linux-next: build failure after merge of the fbdev tree

linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi all,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/video/fbdev/sstfb.c: In function 'sstfb_probe':
drivers/video/fbdev/sstfb.c:1439:2: error: invalid preprocessing directive #fdef; did you mean #ifdef?
 1439 | #fdef CONFIG_FB_DEVICE
      |  ^~~~
      |  ifdef
drivers/video/fbdev/sstfb.c:1442:2: error: #endif without #if
 1442 | #endif
      |  ^~~~~

Caused by commit

  7c0510bb3452 ("fbdev: sstfb: Make CONFIG_FB_DEVICE optional")

I have used the fbdev tree from next-20241014 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the fbdev tree

[Thomas Zimmermann]

Hi

Am 15.10.24 um 03:01 schrieb Stephen Rothwell:
> Hi all,
>
> After merging the fbdev tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/video/fbdev/sstfb.c: In function 'sstfb_probe':
> drivers/video/fbdev/sstfb.c:1439:2: error: invalid preprocessing directive #fdef; did you mean #ifdef?
>   1439 | #fdef CONFIG_FB_DEVICE
>        |  ^~~~
>        |  ifdef
> drivers/video/fbdev/sstfb.c:1442:2: error: #endif without #if
>   1442 | #endif
>        |  ^~~~~
>
> Caused by commit
>
>    7c0510bb3452 ("fbdev: sstfb: Make CONFIG_FB_DEVICE optional")
>
> I have used the fbdev tree from next-20241014 for today.

Thanks for reporting. While it has my r-b, it wasn't supposed to be 
merged yet. I sent out a fix to address the remaining problems. See

https://lore.kernel.org/linux-fbdev/20241015071029.25639-1-tzimmermann@suse.de/T/#u

Best regards
Thomas

>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Re: linux-next: build failure after merge of the fbdev tree

[Helge Deller]

On 10/15/24 09:15, Thomas Zimmermann wrote:
> Hi
>
> Am 15.10.24 um 03:01 schrieb Stephen Rothwell:
>> Hi all,
>>
>> After merging the fbdev tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/video/fbdev/sstfb.c: In function 'sstfb_probe':
>> drivers/video/fbdev/sstfb.c:1439:2: error: invalid preprocessing directive #fdef; did you mean #ifdef?
>>   1439 | #fdef CONFIG_FB_DEVICE
>>        |  ^~~~
>>        |  ifdef
>> drivers/video/fbdev/sstfb.c:1442:2: error: #endif without #if
>>   1442 | #endif
>>        |  ^~~~~
>>
>> Caused by commit
>>
>>    7c0510bb3452 ("fbdev: sstfb: Make CONFIG_FB_DEVICE optional")
>>
>> I have used the fbdev tree from next-20241014 for today.
>
> Thanks for reporting. While it has my r-b, it wasn't supposed to be merged yet. I sent out a fix to address the remaining problems. See
>
> https://lore.kernel.org/linux-fbdev/20241015071029.25639-1-tzimmermann@suse.de/T/#u

Thanks Thomas and Stephen!

I've merged Thomas changes into one patch and pushed a new version.
The issue should be resolved now.

Helge

linux-next: build failure after merge of the fbdev tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

Hi all,

After merging the fbdev tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

x86_64-linux-gnu-ld: vmlinux.o: in function `au1100fb_drv_remove':
au1100fb.c:(.text+0x251e220): undefined reference to `unregister_framebuffer'
x86_64-linux-gnu-ld: au1100fb.c:(.text+0x251e22c): undefined reference to `fb_dealloc_cmap'
x86_64-linux-gnu-ld: vmlinux.o: in function `au1100fb_setup':
au1100fb.c:(.text+0x251ec0f): undefined reference to `fb_get_options'
x86_64-linux-gnu-ld: vmlinux.o: in function `au1100fb_drv_probe':
au1100fb.c:(.text+0x252096f): undefined reference to `fb_alloc_cmap'
x86_64-linux-gnu-ld: au1100fb.c:(.text+0x2520997): undefined reference to `register_framebuffer'
x86_64-linux-gnu-ld: au1100fb.c:(.text+0x2520c08): undefined reference to `fb_dealloc_cmap'
x86_64-linux-gnu-ld: vmlinux.o: in function `BSWAP_SHUFB_CTL':
sha1-avx2-asm.o:(.rodata+0xc38498): undefined reference to `fb_io_read'
x86_64-linux-gnu-ld: sha1-avx2-asm.o:(.rodata+0xc384a0): undefined reference to `fb_io_write'
x86_64-linux-gnu-ld: sha1-avx2-asm.o:(.rodata+0xc384d8): undefined reference to `cfb_fillrect'
x86_64-linux-gnu-ld: sha1-avx2-asm.o:(.rodata+0xc384e0): undefined reference to `cfb_copyarea'
x86_64-linux-gnu-ld: sha1-avx2-asm.o:(.rodata+0xc384e8): undefined reference to `cfb_imageblit'
make[3]: *** [/tmp/next/build/scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
make[2]: *** [/tmp/next/build/Makefile:1280: vmlinux] Error 2

Caused by commit

  c357150378862b (fbdev: au1100fb: Make driver compilable on non-mips platforms)

I have used the version from 20260205 instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi all,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/video/fbdev/omap2/omapfb/dss/dss.c: In function 'dss_add_child_component':
drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:49: error: 'component_compare_dev' undeclared (first use in this function); did you mean 'component_master_del'?
 1209 |         component_match_add(dev->parent, match, component_compare_dev, dev);
      |                                                 ^~~~~~~~~~~~~~~~~~~~~
      |                                                 component_master_del

Caused by commit

  61038027aa13 ("video: fbdev: omapfb: Make use of the helper component_compare_dev")

I have used the fbdev tree from next-20220215 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the fbdev tree

[Helge Deller]

On 2/16/22 01:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the fbdev tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/video/fbdev/omap2/omapfb/dss/dss.c: In function 'dss_add_child_component':
> drivers/video/fbdev/omap2/omapfb/dss/dss.c:1209:49: error: 'component_compare_dev' undeclared (first use in this function); did you mean 'component_master_del'?
>  1209 |         component_match_add(dev->parent, match, component_compare_dev, dev);
>       |                                                 ^~~~~~~~~~~~~~~~~~~~~
>       |                                                 component_master_del
>
> Caused by commit
>
>   61038027aa13 ("video: fbdev: omapfb: Make use of the helper component_compare_dev")
>
> I have used the fbdev tree from next-20220215 for today.

Thanks Steven!
I've dropped that patch now, so your next pull should be fine.

Helge

linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) failed like this:

x86_64-linux-gnu-ld: drivers/gpu/vga/vga_switcheroo.o: in function `vga_switchto_stage2':
vga_switcheroo.c:(.text+0x997): undefined reference to `fbcon_remap_all'

Caused by commit

  1cd51b5d200d ("vgaswitcheroo: call fbcon_remap_all directly")

I have used the version of the fbdev tree from next-20190619 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi all,

On Thu, 20 Jun 2019 11:41:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the fbdev tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> x86_64-linux-gnu-ld: drivers/gpu/vga/vga_switcheroo.o: in function `vga_switchto_stage2':
> vga_switcheroo.c:(.text+0x997): undefined reference to `fbcon_remap_all'
> 
> Caused by commit
> 
>   1cd51b5d200d ("vgaswitcheroo: call fbcon_remap_all directly")
> 
> I have used the version of the fbdev tree from next-20190619 for today.

I am still getting this failure.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

Hi all,

On Mon, 24 Jun 2019 11:45:38 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 20 Jun 2019 11:41:26 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the fbdev tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > x86_64-linux-gnu-ld: drivers/gpu/vga/vga_switcheroo.o: in function `vga_switchto_stage2':
> > vga_switcheroo.c:(.text+0x997): undefined reference to `fbcon_remap_all'
> > 
> > Caused by commit
> > 
> >   1cd51b5d200d ("vgaswitcheroo: call fbcon_remap_all directly")
> > 
> > I have used the version of the fbdev tree from next-20190619 for today.  
> 
> I am still getting this failure.

This has now been merged into the drm-intel and drm trees :-( .
Something has gone wrong as Daniel was cc'd on the original build
failure report.

I have reverted commits

  1cd51b5d200d ("vgaswitcheroo: call fbcon_remap_all directly")
  fe2d70d6f6ff ("fbcon: Call con2fb_map functions directly")

for today.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 530 bytes --]

Hi Bartlomiej,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "dummycon_unregister_output_notifier" [drivers/video/fbdev/core/fb.ko] undefined!
ERROR: "dummycon_register_output_notifier" [drivers/video/fbdev/core/fb.ko] undefined!

Caused by commit

  83d83bebf401 ("console/fbcon: Add support for deferred console takeover")

I have reverted that commit for today.

I note that this commit is in the drm-misc tree as well.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: linux-next: build failure after merge of the fbdev tree

[Hans de Goede]

Hi,

On 29-06-18 03:07, Stephen Rothwell wrote:
> Hi Bartlomiej,
> 
> After merging the fbdev tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "dummycon_unregister_output_notifier" [drivers/video/fbdev/core/fb.ko] undefined!
> ERROR: "dummycon_register_output_notifier" [drivers/video/fbdev/core/fb.ko] undefined!
> 
> Caused by commit
> 
>    83d83bebf401 ("console/fbcon: Add support for deferred console takeover")
> 
> I have reverted that commit for today.
> 
> I note that this commit is in the drm-misc tree as well.

Ugh, my bad. I did not take the fb code being modular into account
here. I will submit a follow up patch fixing this today.

Regards,

Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

linux-next: build failure after merge of the fbdev tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Paul,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/video/s3fb.c:29:26: error: linux/i2c-id.h: No such file or directory

Caused by commit f4d186dc6a28 ("s3fb: add DDC support").

I have used the version of the fbdev tree from next-20110406 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]