From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DF5C4167D for ; Fri, 25 Nov 2022 08:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbiKYIw5 (ORCPT ); Fri, 25 Nov 2022 03:52:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbiKYIw4 (ORCPT ); Fri, 25 Nov 2022 03:52:56 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C60DB1F2EE for ; Fri, 25 Nov 2022 00:52:54 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id g12so5887235lfh.3 for ; Fri, 25 Nov 2022 00:52:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2HOoSTuq4XmGVlN86fKAOkleTlxcvh89psdCg1LMg4A=; b=xVID0zJQJp2QJkmW1SBo32zh8XH3xzkv8aG8WeB96TzyJI45ZN8ROc4yikA+WlfIQN YyIXuVTCii3kyRz0MzUiFJkPtWFp3OSIoMcY+xY6bX/spvJbiHZjhTZ31geefUTYZaKu 9prcSyg5At5TqqA6ZDHeBr16S13v/28Jipge+rEqVwMZjZYR+DkWKtTc+lN7WNvNuivO CSlDphVEdhoaW3N2m6mUg8mLGMCOIXVZ9w3N80Cwwctel85dPOwdX6IDsvlyvqOzmTuv ROPNdfwidvk4XXRFmBoIWpbL5H3G6YblZCZiLyVWpytqTSCBPNLuZCjWrgGX05b6RKel q5Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2HOoSTuq4XmGVlN86fKAOkleTlxcvh89psdCg1LMg4A=; b=f4IeDxzLcqTNfwdAThJDiFQIK7Ls9RNqBw8lWrFs1h6mnVDf/x3o391Pjf8XQMTm6a 0vx3wnnKPBBJZPfWDLpjbyqoN+9M//pxDDf/OZeU9nU0SlHwryysqaclMxLBGhiQNa/h la5nGzdGsoiH/RXu/O6DzUAYGRWLRdh2Ep8Oo7jVEo9PJbCPwwsjpgF+cIoV+ciQmafn e6OUeyaq4HeR3LrWXkrD8ZSXNTT9koFc6VVAZJ/4IVW3kmsBoqjqb9Xh8elS2uq+0o4O 3IphAG2LL3xHe9zISNcDCIHYuBdRIDAf3R0zP0skW6ZQIRNt3YSAFBEL21HtBbxE190a 7S4g== X-Gm-Message-State: ANoB5pmwfu3Aklz5mqXMy+o/5lnq4D9x9+l/849KAMNUSMGbYYi68FLo ipecB4SJx0tS/R+6sKCFgiPBaA== X-Google-Smtp-Source: AA0mqf5hdKwX1Jr/0xm1ekWXXWPH7sNyiUXb+ircocZn1YbXicl7J/ecMU+IwqFeLH/p3Uc4Rr4QNw== X-Received: by 2002:a19:381c:0:b0:4ae:d4db:9f89 with SMTP id f28-20020a19381c000000b004aed4db9f89mr8034920lfa.174.1669366373160; Fri, 25 Nov 2022 00:52:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id a4-20020a2eb164000000b0026dd24dc4ecsm294276ljm.82.2022.11.25.00.52.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 00:52:52 -0800 (PST) Message-ID: <7f5cf3d8-4a3b-41eb-fed9-1ade4ba1e4e2@linaro.org> Date: Fri, 25 Nov 2022 09:52:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ARM: s3c: Fix a build error after the s3c24xx dma driver was removed Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Vinod Koul Cc: Arnd Bergmann , kernel@pengutronix.de, linux-samsung-soc@vger.kernel.org, Ben Dooks , linux-kernel@vger.kernel.org, Alim Akhtar , dmaengine@vger.kernel.org, Simtec Linux Team , linux-next@vger.kernel.org References: <20221021203329.4143397-14-arnd@kernel.org> <20221118215401.505480-1-u.kleine-koenig@pengutronix.de> <20221125085117.23p7yv6wgo6b5l3v@pengutronix.de> From: Krzysztof Kozlowski In-Reply-To: <20221125085117.23p7yv6wgo6b5l3v@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 25/11/2022 09:51, Uwe Kleine-König wrote: > Hello, > > On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote: >> On 20/11/2022 11:31, Krzysztof Kozlowski wrote: >>> On 18/11/2022 22:54, Uwe Kleine-König wrote: >>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't >>>> declare or define any symbol needed in devs.c though, so the #include >>>> can just be dropped. >>>> >>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver") >>>> Signed-off-by: Uwe Kleine-König >>>> --- >>> >>> The file was not removed... or it should not have been yet. The s3c24xx >>> dma driver removal should be part of Arnd series taken via SoC ARM. > > The patch enters next with the merge of > > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next > > Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a > bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still > broken) and patch #2 includes the change I suggested here. > >> I think that commit should be just dropped instead. > > +1 > > BTW, cccc46ae3623 is included in next since next-20221107 and breaks > (at least) arm/s3c2410_defconfig. So I would consider reverting > cccc46ae3623 a fix. (Added linux-next to Cc:) Yes. The build failure of next was reported already by kernel test robot. Vinod, can we drop this patch? Best regards, Krzysztof