From: Matthieu Baerts <matttbe@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Yiqi Sun <sunyiqixm@gmail.com>,
horms@kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
dsahern@kernel.org, edumazet@google.com, pabeni@redhat.com,
Mark Brown <broonie@kernel.org>,
linux-next@vger.kernel.org
Subject: Re: [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe(): manual merge
Date: Mon, 6 Apr 2026 18:10:14 +0200 [thread overview]
Message-ID: <80348cc5-195d-4acf-9d20-2ddc0da92ef5@kernel.org> (raw)
In-Reply-To: <20260406083615.32f44e4f@kernel.org>
Hi Jakub,
Thank you for your reply!
On 06/04/2026 17:36, Jakub Kicinski wrote:
> On Mon, 6 Apr 2026 12:48:28 +0200 Matthieu Baerts wrote:
>> - dev = ipv6_stub->ipv6_dev_find(net, &iio->ident.addr.ip_addr.ipv6_addr, dev);
>> + dev = ipv6_dev_find(net, &iio->ident.addr.ip_addr.ipv6_addr, dev);
>> + /*
>> + * If IPv6 identifier lookup is unavailable, silently
>> + * discard the request instead of misreporting NO_IF.
>> + */
>> + if (IS_ERR(dev))
>> + return false;
>> +
>> dev_hold(dev);
>> break;
>
> See my reply, AFAIU we can just delete this new check in net-next.
Good idea.
Should this not be done in an explicit patch, rather than "hidden"
during the merge?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-04-06 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260402070419.2291578-1-sunyiqixm@gmail.com>
2026-04-06 10:48 ` [PATCH net] ipv4: icmp: fix null-ptr-deref in icmp_build_probe(): manual merge Matthieu Baerts
2026-04-06 15:36 ` Jakub Kicinski
2026-04-06 16:10 ` Matthieu Baerts [this message]
2026-04-06 16:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80348cc5-195d-4acf-9d20-2ddc0da92ef5@kernel.org \
--to=matttbe@kernel.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sunyiqixm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox