From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F90C433F5 for ; Thu, 29 Sep 2022 16:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236260AbiI2Q0B (ORCPT ); Thu, 29 Sep 2022 12:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236229AbiI2QZh (ORCPT ); Thu, 29 Sep 2022 12:25:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99B2E14B862; Thu, 29 Sep 2022 09:23:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 27CF1B81E59; Thu, 29 Sep 2022 16:22:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE28EC433C1; Thu, 29 Sep 2022 16:22:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664468560; bh=9yXgBxaJ3Q0rRwsuLMoJ/dGgauAI5CmQu2mfg5Sp3xA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EX5L/6RIoWE5eGk7Y070p/Qqp+xedYXVkdSmANS+1gJ/vAZ9Kg3+HXKvMLCWc/k1Q PCo8qNGypaVbZ7QgzH3MYAPQ5enOsYjs1lnmifm40xXbn2pcxZ2URaXZ3w5qOQD7z0 2f9vmfnqoLoPpscc6xVWXI5V6gSeEl9bcVpYX2ccWgq1Q/he+gAVH70cK/ohk5xXSM Bd7hHl0GHynNkGeau4QCEPG0TkweElJUZNuY3WBuA8c8u7g88MocIzXo9MKk0jE73I rwpSh7XsXtef0Audaqr+7KIFK9ieQxN6YHXLpiNV48lAJHq54X48uYyXuHtB7LEoqV in8cnq5BWPcCA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1odwJ4-00Da9j-Jq; Thu, 29 Sep 2022 17:22:38 +0100 Date: Thu, 29 Sep 2022 17:22:38 +0100 Message-ID: <86czbe6tgx.wl-maz@kernel.org> From: Marc Zyngier To: Robin Murphy Cc: broonie@kernel.org, Joerg Roedel , Frank Li , Will Deacon , Linux Kernel Mailing List , Linux Next Mailing List , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: linux-next: build failure after merge of the irqchip tree In-Reply-To: <7f9d35bf-282f-68cf-b857-3d7e66dbaf63@arm.com> References: <20220929143149.126145-1-broonie@kernel.org> <7f9d35bf-282f-68cf-b857-3d7e66dbaf63@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: robin.murphy@arm.com, broonie@kernel.org, jroedel@suse.de, Frank.Li@nxp.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, 29 Sep 2022 15:40:56 +0100, Robin Murphy wrote: > > On 2022-09-29 15:31, broonie@kernel.org wrote: > > Hi all, > > > > After merging the irqchip tree, today's linux-next build (arm64 > > defconfig) failed like this: > > > > /tmp/next/build/drivers/irqchip/irq-imx-mu-msi.c:14:10: fatal error: linux/dma-iommu.h: No such file or directory > > 14 | #include > > | ^~~~~~~~~~~~~~~~~~~ > > > > Caused by commit > > > > 841e6e9f2bc95baff ("irqchip: Add IMX MU MSI controller driver") > > > > interacting with > > > > f2042ed21da7f8886 ("iommu/dma: Make header private") > > > > I have reverted the driver for today. > > Once again it looks like an unused include which could just be > removed... illustrating a large part of why I took the header away :) Thanks both. I've now fixed the driver by dropping this include (and another one) and pushed the -next branch out again. M. -- Without deviation from the norm, progress is not possible.