From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Shyam_Iyer@Dell.com, jbarnes@virtuousgeek.org,
mjg59@srcf.ucam.org, Narendra_K@Dell.com,
viro@zeniv.linux.org.uk, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Matt_Domsch@Dell.com, Charles_Rose@Dell.com,
Jordan_Hargrave@Dell.com
Subject: Re: [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig
Date: Wed, 30 Mar 2011 01:39:46 +0900 [thread overview]
Message-ID: <8739m5519p.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <4D92063C.8040202@oracle.com> (Randy Dunlap's message of "Tue, 29 Mar 2011 09:18:04 -0700")
Randy Dunlap <randy.dunlap@oracle.com> writes:
>> config PCI_LABEL
>> bool
>> select NLS
>> depends on (DMI || ACPI)
>
> What sets/enables it then?
> or did you mean:
> def_bool y
> and in that case, should it be a user-visible & user-changeable kconfig option?
Whoops, last line was missed by copy&paste. It meant
config PCI_LABEL
bool
select NLS
depends on (DMI || ACPI)
default y
And no, it shouldn't be user-changeable (it would be better to
invisible in .config. At make *config, already invisible.). Because
PCI_LABEL is not user config and not used in Makefile.
And yeah, if you like def_bool
config PCI_LABEL
def_bool y if (DMI || ACPI)
select NLS
I guess it would work (it should be just syntax sugar and equivalent).
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2011-03-29 16:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 12:54 [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-02-23 13:17 ` Matthew Garrett
2011-03-04 18:15 ` Jesse Barnes
2011-03-28 15:02 ` Randy Dunlap
2011-03-28 16:17 ` Jesse Barnes
2011-03-28 19:14 ` Shyam_Iyer
2011-03-28 20:22 ` Randy Dunlap
2011-03-29 1:55 ` OGAWA Hirofumi
2011-03-29 16:18 ` Randy Dunlap
2011-03-29 16:23 ` Jesse Barnes
2011-03-29 16:39 ` OGAWA Hirofumi [this message]
2011-03-29 16:45 ` [PATCH] pci-label: " Randy Dunlap
2011-03-29 16:55 ` Jesse Barnes
2011-03-31 9:27 ` Narendra_K
2011-04-19 6:06 ` [PATCH] " Ingo Molnar
2011-04-19 8:43 ` Narendra_K
2011-04-19 16:25 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2011-01-12 20:10 CONFIG_NLS=m resulting in undefined reference to utf16s_to_utf8s causing build failure Narendra_K
2011-01-13 0:02 ` Jesse Barnes
2011-01-13 3:23 ` Len Brown
2011-01-13 15:55 ` Jesse Barnes
2011-01-13 16:03 ` Narendra_K
2011-01-14 15:22 ` [PATCH] Fix build failure when CONFIG_NLS is set to 'm' by allmodconfig Narendra_K
2011-01-14 15:29 ` Sedat Dilek
2011-01-14 16:06 ` Narendra_K
2011-01-14 21:09 ` Stephen Rothwell
2011-01-17 19:28 ` Narendra_K
2011-01-20 18:41 ` Narendra_K
2011-01-28 15:30 ` Narendra_K
2011-01-28 16:45 ` Jesse Barnes
2011-02-01 16:28 ` Narendra_K
2011-02-01 16:59 ` Narendra_K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739m5519p.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=Charles_Rose@Dell.com \
--cc=Jordan_Hargrave@Dell.com \
--cc=Matt_Domsch@Dell.com \
--cc=Narendra_K@Dell.com \
--cc=Shyam_Iyer@Dell.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).