From: Chandan Babu R <chandanbabu@kernel.org>
To: Alexander Mikhalitsyn <alexander@mihalicyn.com>
Cc: linux-next@vger.kernel.org, mszeredi@redhat.com,
Christian Brauner <brauner@kernel.org>
Subject: Re: [BUG REPORT] linux-next/fs-next released on 6th September fails to boot
Date: Tue, 10 Sep 2024 13:21:33 +0530 [thread overview]
Message-ID: <877cbkaque.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <CAJqdLrpwuaPG3PoFwbxPRp8GrbEWooXazrMZgV4Wj=FK=vq=6A@mail.gmail.com>
On Mon, Sep 09, 2024 at 05:56:11 PM +0200, Alexander Mikhalitsyn wrote:
> Dear Chandan,
>
> Please can you check if the following patch resolves issue for your workload:
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 7885f071fa1e..f130b23d6850 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -148,7 +148,7 @@ static struct fuse_req *fuse_get_req(struct
> mnt_idmap *idmap,
> if (for_background)
> __set_bit(FR_BACKGROUND, &req->flags);
>
> - if ((fm->sb->s_iflags & SB_I_NOIDMAP) || idmap) {
> + if (!fm->sb || (fm->sb->s_iflags & SB_I_NOIDMAP) || idmap) {
> kuid_t idmapped_fsuid;
> kgid_t idmapped_fsgid;
>
> From your call stack if looks caused by CUSE case.
> It's my bad that I have not considered this use case for
> fuse_get_req() and there is, obviously,
> no such thing as fm->sb for CUSE scenario.
>
The above patch solves the problem. Thank you!
--
Chandan
next prev parent reply other threads:[~2024-09-10 7:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 8:23 [BUG REPORT] linux-next/fs-next released on 6th September fails to boot Chandan Babu R
2024-09-09 10:38 ` Alexander Mikhalitsyn
2024-09-09 10:40 ` Christian Brauner
2024-09-09 10:55 ` Alexander Mikhalitsyn
2024-09-09 11:00 ` Christian Brauner
2024-09-09 11:03 ` Alexander Mikhalitsyn
2024-09-09 11:07 ` Christian Brauner
2024-09-09 11:19 ` Alexander Mikhalitsyn
2024-09-09 12:32 ` Christian Brauner
2024-09-09 12:43 ` Alexander Mikhalitsyn
2024-09-09 15:56 ` Alexander Mikhalitsyn
2024-09-09 16:11 ` Alexander Mikhalitsyn
2024-09-10 6:39 ` Chandan Babu R
2024-09-10 6:50 ` Alexander Mikhalitsyn
2024-09-10 7:51 ` Chandan Babu R [this message]
2024-09-10 7:56 ` Alexander Mikhalitsyn
2024-09-09 11:05 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cbkaque.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=chandanbabu@kernel.org \
--cc=alexander@mihalicyn.com \
--cc=brauner@kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox