From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the l2-mtd tree
Date: Tue, 29 Nov 2011 10:54:37 +0100 [thread overview]
Message-ID: <878vmz8d9e.fsf@free.fr> (raw)
In-Reply-To: <20111129143358.0859ae27c22f2c752a608f65@canb.auug.org.au> (Stephen Rothwell's message of "Tue, 29 Nov 2011 14:33:58 +1100")
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/mtd/devices/docg3.c: In function 'doc_write_page_ecc_init':
> drivers/mtd/devices/docg3.c:577:6: warning: suggest parentheses around operand
> of '!' or change '|' to '||' or '!' to '~' [-Wparentheses]
Hi Stephen,
My fault, I've been too lazy with that commit for too long, and code like
writel(!reg1 | reg2, adr) is error prone. Artem did point out the warning
already, so that's on me.
I'll mend the fix in a V2 to a cleanup patch already submitted to linux-mtd.
Cheers.
--
Robert
PS: there will be another warning about an unused function
doc_get_erase_count(). This one will be fixed a bit later I'm afraid.
next prev parent reply other threads:[~2011-11-29 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 3:33 linux-next: build warning after merge of the l2-mtd tree Stephen Rothwell
2011-11-29 9:54 ` Robert Jarzmik [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-23 1:32 Stephen Rothwell
2017-06-23 4:56 ` Rafał Miłecki
2017-06-23 17:59 ` Brian Norris
2017-07-24 1:48 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vmz8d9e.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).