From mboxrd@z Thu Jan  1 00:00:00 1970
From: ebiederm@xmission.com (Eric W. Biederman)
Subject: Re: linux-next: build failure after merge of the userns tree
Date: Thu, 25 Jan 2018 20:45:53 -0600
Message-ID: <87fu6ttk0u.fsf@xmission.com>
References: <20180126120512.1b431ac7@canb.auug.org.au>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <linux-next-owner@vger.kernel.org>
Received: from out02.mta.xmission.com ([166.70.13.232]:43179 "EHLO
        out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751465AbeAZCqz (ORCPT
        <rfc822;linux-next@vger.kernel.org>); Thu, 25 Jan 2018 21:46:55 -0500
In-Reply-To: <20180126120512.1b431ac7@canb.auug.org.au> (Stephen Rothwell's
        message of "Fri, 26 Jan 2018 12:05:12 +1100")
Sender: linux-next-owner@vger.kernel.org
List-ID: <linux-next.vger.kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Ram Pai <linuxram@us.ibm.com>

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> After merging the userns tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> arch/powerpc/kernel/mce.c: In function 'machine_process_ue_event':
> arch/powerpc/kernel/mce.c:276:5: error: too many arguments to function 'memory_failure'
>      memory_failure(pfn, SIGBUS, 0);
>      ^~~~~~~~~~~~~~
> In file included from include/linux/pid_namespace.h:7:0,
>                  from include/linux/ptrace.h:10,
>                  from arch/powerpc/kernel/mce.c:27:
> include/linux/mm.h:2571:12: note: declared here
>  extern int memory_failure(unsigned long pfn, int flags);
>             ^~~~~~~~~~~~~~
>
> Caused by commit
>
>   83b57531c58f ("mm/memory_failure: Remove unused trapno from memory_failure")
>
> I have added the following patch for today:

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

The patch below is correct, and it really makes me appreciate my removal
of unused trapno parameter.  

Thank you for catching that.

Eric


> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 26 Jan 2018 11:54:39 +1100
> Subject: [PATCH] mm/memory_failure: update powerpc for memory_failure() API change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  arch/powerpc/kernel/mce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
> index d2fecaec4fec..efdd16a79075 100644
> --- a/arch/powerpc/kernel/mce.c
> +++ b/arch/powerpc/kernel/mce.c
> @@ -273,7 +273,7 @@ static void machine_process_ue_event(struct work_struct *work)
>  
>  				pfn = evt->u.ue_error.physical_address >>
>  					PAGE_SHIFT;
> -				memory_failure(pfn, SIGBUS, 0);
> +				memory_failure(pfn, 0);
>  			} else
>  				pr_warn("Failed to identify bad address from "
>  					"where the uncorrectable error (UE) "
> -- 
> 2.15.1