From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
linux-next <linux-next@vger.kernel.org>,
linux-netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Kernel crash on startup - bisected to commit 3b24d854cb35
Date: Mon, 11 Apr 2016 15:40:38 +0300 [thread overview]
Message-ID: <87inzoz5bt.fsf@purkki.adurom.net> (raw)
In-Reply-To: <570934C9.5020008@lwfinger.net> (Larry Finger's message of "Sat, 9 Apr 2016 11:58:49 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
>> Can you double check you have this fix ?
>>
>> commit 8501786929de4616b10b8059ad97abd304a7dddf
>> Author: Eric Dumazet <edumazet@google.com>
>> Date: Wed Apr 6 22:07:34 2016 -0700
>>
>> tcp/dccp: fix inet_reuseport_add_sock()
>>
>> David Ahern reported panics in __inet_hash() caused by my recent commit.
>>
>> The reason is inet_reuseport_add_sock() was still using
>> sk_nulls_for_each_rcu() instead of sk_for_each_rcu().
>> SO_REUSEPORT enabled listeners were causing an instant crash.
>>
>> While chasing this bug, I found that I forgot to clear SOCK_RCU_FREE
>> flag, as it is inherited from the parent at clone time.
>>
>> Fixes: 3b24d854cb35 ("tcp/dccp: do not touch listener sk_refcnt
>> under synflood")
>> Signed-off-by: Eric Dumazet <edumazet@google.com>
>> Reported-by: David Ahern <dsa@cumulusnetworks.com>
>> Tested-by: David Ahern <dsa@cumulusnetworks.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> No, I did not have that patch. After pulling from net-next to get it,
> my system no longer panics.
>
> Note to linux-wireless readers. At the moment, a system built from
> wireless-drivers-next will have this problem.
I'm currently writing a pull request to Dave and once he pulls it I'll
fast forward wireless-drivers-next to latest net-next. Usually this take
two days or so.
--
Kalle Valo
prev parent reply other threads:[~2016-04-11 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <570892F9.9030700@lwfinger.net>
2016-04-09 5:33 ` Kernel crash on startup - bisected to commit 3b24d854cb35 Eric Dumazet
2016-04-09 16:58 ` Larry Finger
2016-04-11 12:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inzoz5bt.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-netdev@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).