From: Kalle Valo <kvalo@codeaurora.org>
To: Sinan Kaya <okaya@kernel.org>
Cc: Luciano Coelho <luciano.coelho@intel.com>,
linux-next@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS
Date: Tue, 22 Jan 2019 18:17:52 +0200 [thread overview]
Message-ID: <87munsmztb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <d00c99a7-423a-9a70-5f50-f95c5d044f85@kernel.org> (Sinan Kaya's message of "Tue, 22 Jan 2019 11:12:06 -0500")
Sinan Kaya <okaya@kernel.org> writes:
> On 1/22/2019 5:15 AM, Luciano Coelho wrote:
>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
>>> There is an unresolved dependency as follows:
>>>
>>> IWLWIFI_LEDS selects MAC80211_LEDS.
>>> MAC80211_LEDS depends on MAC80211.
>>>
>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
>>> (n)
>>>
>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>>> Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
>>> LEDS_CLASS [=y]
>>> Selected by [y]:
>>> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
>>> LEDS_CLASS [=y]=IWLWIFI [=y])
>>>
>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
>>> configuration.
>>>
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>
>> Thanks for your patch! But we already have another patch to fix this
>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
>>
>> https://patchwork.kernel.org/patch/10762079/
>
> Is it possible to queue this up soon? There is an effort to clean up
> linux-next against randconfig failures and this issue showed up there.
It already should be in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1
But it's not in Linus' tree, yet.
--
Kalle Valo
next prev parent reply other threads:[~2019-01-22 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 23:31 [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Sinan Kaya
2019-01-22 10:15 ` Luciano Coelho
2019-01-22 16:12 ` Sinan Kaya
2019-01-22 16:17 ` Kalle Valo [this message]
2019-01-22 16:20 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87munsmztb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox