From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH next v2] drivers/net/wireless/ath/wil6210/debugfs.c: Use 'uint64_t' instead of 'cycles_t' to avoid warnings Date: Wed, 07 Jan 2015 19:51:45 +0200 Message-ID: <87oaqaqy1a.fsf@kamboji.qca.qualcomm.com> References: <549AD6FC.8060706@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <549AD6FC.8060706@gmail.com> (Chen Gang's message of "Wed, 24 Dec 2014 23:08:44 +0800") Sender: netdev-owner@vger.kernel.org To: Chen Gang Cc: qca_vkondrat@qca.qualcomm.com, linux-wireless@vger.kernel.org, wil6210@qca.qualcomm.com, netdev@vger.kernel.org, linux-next@vger.kernel.org List-Id: linux-next.vger.kernel.org Chen Gang writes: > do_div() checks the type strictly. 'cycles_t' may be 32-bit under qui= te > a few architectures (parisc, arm, avr32 ...). So use 'uint64_t' inste= ad > of, the related warning (with allmodconfig under parisc): > > CC [M] drivers/net/wireless/ath/wil6210/debugfs.o > In file included from arch/parisc/include/generated/asm/div64.h:1:0= , > from include/linux/kernel.h:124, > from include/linux/list.h:8, > from include/linux/module.h:9, > from drivers/net/wireless/ath/wil6210/debugfs.c:17= : > drivers/net/wireless/ath/wil6210/debugfs.c: In function =E2=80=98wi= l_vring_debugfs_show=E2=80=99: > include/asm-generic/div64.h:43:28: warning: comparison of distinct = pointer types lacks a cast > (void)(((typeof((n)) *)0) =3D=3D ((uint64_t *)0)); \ > ^ > drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansio= n of macro =E2=80=98do_div=E2=80=99 > do_div(idle, total); > ^ > In file included from include/uapi/linux/stddef.h:1:0, > from include/linux/stddef.h:4, > from ./include/uapi/linux/posix_types.h:4, > from include/uapi/linux/types.h:13, > from include/linux/types.h:5, > from include/linux/list.h:4, > from include/linux/module.h:9, > from drivers/net/wireless/ath/wil6210/debugfs.c:17= : > include/asm-generic/div64.h:44:18: warning: right shift count >=3D = width of type [-Wshift-count-overflow] > if (likely(((n) >> 32) =3D=3D 0)) { \ > ^ > include/linux/compiler.h:159:40: note: in definition of macro =E2=80= =98likely=E2=80=99 > # define likely(x) __builtin_expect(!!(x), 1) > ^ > drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansio= n of macro =E2=80=98do_div=E2=80=99 > do_div(idle, total); > ^ > In file included from arch/parisc/include/generated/asm/div64.h:1:0= , > from include/linux/kernel.h:124, > from include/linux/list.h:8, > from include/linux/module.h:9, > from drivers/net/wireless/ath/wil6210/debugfs.c:17= : > include/asm-generic/div64.h:48:22: warning: passing argument 1 of =E2= =80=98__div64_32=E2=80=99 from incompatible pointer type [-Wincompatibl= e-pointer-types] > __rem =3D __div64_32(&(n), __base); \ > ^ > drivers/net/wireless/ath/wil6210/debugfs.c:107:4: note: in expansio= n of macro =E2=80=98do_div=E2=80=99 > do_div(idle, total); > ^ > include/asm-generic/div64.h:35:17: note: expected =E2=80=98uint64_t= * {aka long long unsigned int *}=E2=80=99 but argument is of type =E2=80= =98cycles_t * {aka long unsigned int *}=E2=80=99 > extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor); > ^ > > Signed-off-by: Chen Gang Thanks, applied to wireless-drivers-next.git. But I simplified the title: c20e7789be9f wil6210: use 'uint64_t' instead of 'cycles_t' to avoid war= nings --=20 Kalle Valo