linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	 Yury Norov <yury.norov@gmail.com>,
	 Boris Brezillon <boris.brezillon@collabora.com>,
	Richard Genoud <richard.genoud@bootlin.com>,
	 Geert Uytterhoeven <geert+renesas@glider.be>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	 Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the bitmap tree
Date: Fri, 28 Nov 2025 09:17:08 +0100	[thread overview]
Message-ID: <87pl92sha3.fsf@bootlin.com> (raw)
In-Reply-To: <CAMuHMdWpiTwp=mH8uj71NqzWctWUQymT3BqwSRTCO7xOa3bbWQ@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 25 Nov 2025 09:05:48 +0100")

Hello,

>> Caused by commit
>>
>>   c1c6ab80b25c ("bitfield: Add non-constant field_{prep,get}() helpers")
>>
>> interacting with commits
>>
>>   d21b4338159f ("mtd: rawnand: sunxi: introduce ecc_mode_mask in sunxi_nfc_caps")
>>   6fc2619af1eb ("mtd: rawnand: sunxi: rework pattern found registers")
>>
>> from the nand tree.
>>
>> I have applied the following hack for today.
>>
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Tue, 25 Nov 2025 17:47:46 +1100
>> Subject: [PATCH] fix up for "bitfield: Add non-constant field_{prep,get}()
>>  helpers"
>>
>> interacting with commits
>>
>>   d21b4338159f ("mtd: rawnand: sunxi: introduce ecc_mode_mask in sunxi_nfc_caps")
>>   6fc2619af1eb ("mtd: rawnand: sunxi: rework pattern found registers")
>>
>> from the nand tree.
>>
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> ---
>>  drivers/mtd/nand/raw/sunxi_nand.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
>> index 031ab651c5a8..b940eb5cf79a 100644
>> --- a/drivers/mtd/nand/raw/sunxi_nand.c
>> +++ b/drivers/mtd/nand/raw/sunxi_nand.c
>> @@ -30,8 +30,8 @@
>>  #include <linux/reset.h>
>>
>>  /* non compile-time field get/prep */
>> -#define field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
>> -#define field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
>> +#define sunxi_field_get(_mask, _reg) (((_reg) & (_mask)) >> (ffs(_mask) - 1))
>> +#define sunxi_field_prep(_mask, _val) (((_val) << (ffs(_mask) - 1)) & (_mask))
>
> See "[PATCH -next v6 11/26] mtd: rawnand: sunxi: #undef
> field_{get,prep}() before local definition"[1] and follow-up
> "[PATCH -next v6 24/26] mtd: rawnand: sunxi: Convert to common
> field_{get,prep}() helpers"[2].
> The former unfortunately didn't make it into the nand tree yet...
>
> [1]
> https://lore.kernel.org/all/703d7eec56074148daed4ea45b637f8a83f15305.1762435376.git.geert+renesas@glider.be

I've had some issues since a distribution update, but I've taken the patch
locally and prepared my branch for the merge window, I cannot push to
the MTD repository right now but it will be done tonight.

Thanks,
Miquèl

  parent reply	other threads:[~2025-11-28  8:17 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25  7:24 linux-next: build failure after merge of the bitmap tree Stephen Rothwell
2025-11-25  8:05 ` Geert Uytterhoeven
2025-11-25  8:31   ` Miquel Raynal
2025-11-25  8:37     ` Geert Uytterhoeven
2025-11-25 14:44       ` Yury Norov
2025-11-25 14:55         ` Miquel Raynal
2025-11-25  8:53     ` Miquel Raynal
2025-11-28  8:17   ` Miquel Raynal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-18  5:07 Stephen Rothwell
2025-02-18 10:35 ` Beata Michalska
2025-02-18 13:49   ` Stephen Rothwell
2025-02-18 14:10     ` Catalin Marinas
2025-02-18 14:16       ` Yury Norov
2025-02-18 18:23         ` Catalin Marinas
2025-02-18 19:28           ` Beata Michalska
2025-02-18 19:44             ` Catalin Marinas
2024-05-08  6:27 Stephen Rothwell
2024-05-08 13:24 ` Kuan-Wei Chiu
2024-05-08 22:18   ` Yury Norov
2023-10-20  4:49 Stephen Rothwell
2023-10-19  6:01 Stephen Rothwell
2023-10-19 15:58 ` Yury Norov
2023-10-20  4:24   ` Yury Norov
2023-10-20  4:51     ` Stephen Rothwell
2023-10-20 12:33       ` Yury Norov
2023-11-02 11:41         ` Alexander Lobakin
2022-09-26 23:53 broonie
2022-09-27  0:37 ` Yury Norov
2022-09-27 18:56   ` Mark Brown
2022-09-20  8:08 Stephen Rothwell
2022-09-20 14:49 ` Yury Norov
2022-07-27 10:29 Stephen Rothwell
2022-07-22  9:16 Stephen Rothwell
2022-07-22 19:29 ` Yury Norov
2022-07-15 10:29 Stephen Rothwell
2022-07-08  7:47 Stephen Rothwell
2022-05-02  8:15 Stephen Rothwell
2022-04-19  4:29 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl92sha3.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@collabora.com \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=richard.genoud@bootlin.com \
    --cc=sfr@canb.auug.org.au \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).