From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree Date: Fri, 13 Jan 2017 15:47:41 +0200 Message-ID: <87shonjcle.fsf@codeaurora.org> References: <20170113111250.2023a160@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20170113111250.2023a160@canb.auug.org.au> (Stephen Rothwell's message of "Fri, 13 Jan 2017 11:12:50 +1100") Sender: linux-kernel-owner@vger.kernel.org To: Stephen Rothwell Cc: Kalle Valo , Wireless , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Xinming Hu , Amitkumar Karwar List-Id: linux-next.vger.kernel.org Stephen Rothwell writes: > Hi all, > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) produced this warning: > > drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove': > drivers/net/wireless/marvell/mwifiex/pcie.c:303:5: warning: 'fw_status' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) { > ^ > > Introduced by commit > > 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag") > > This is not a false positive since "reg" could be NULL just above > (otherwise it would be tested for). Thanks, I noticed this myself yesterday (after I had applied the patch) and I have asked Marvell to send a fix. -- Kalle Valo