From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Dan Streetman <ddstreet@ieee.org>,
linux-next@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS
Date: Sun, 28 Jun 2015 14:51:14 +0930 [thread overview]
Message-ID: <87vbe8s911.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150627102134.00e58047@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Rusty,
>
> On Thu, 25 Jun 2015 17:34:31 -0400 Dan Streetman <ddstreet@ieee.org> wrote:
>>
>> On Thu, Jun 25, 2015 at 5:18 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>> > Dan Streetman <ddstreet@ieee.org> writes:
>> >> Only include the built-in and per-module param_lock, and corresponding
>> >> lock/unlock functions, if sysfs is enabled. If there is no sysfs there
>> >> is no need for locking kernel params.
>> >>
>> >> This fixes a build break when CONFIG_SYSFS is not enabled, introduced
>> >> by commit b51d23e.
>> >
>> > This doesn't even come close to applying to my tree?
>>
>> sorry, I had the !CONFIG_MODULES patch in my tree also, so this was on
>> top of that one:
>> https://lkml.org/lkml/2015/6/24/550
>>
>> I can resend that one, on top of this one, or you can fix it up.
>>
>> Sorry for not getting it right the first time ;-)
>
> This is what I ended up applying to yesterday's linux-next:
Thanks, added correct description to previous patch and applied this
on top.
Sorry for the hassle,
Rusty.
next prev parent reply other threads:[~2015-06-28 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 6:54 linux-next: build failure after merge of the modules tree Stephen Rothwell
2015-06-25 9:51 ` Dan Streetman
2015-06-25 13:04 ` [PATCH] modules: elide param_lock if !CONFIG_SYSFS Dan Streetman
2015-06-25 21:18 ` Rusty Russell
2015-06-25 21:34 ` Dan Streetman
2015-06-27 0:21 ` Stephen Rothwell
2015-06-28 5:21 ` Rusty Russell [this message]
2015-06-25 22:39 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbe8s911.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).