From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time" Date: Tue, 21 Jul 2015 14:57:44 +0900 Message-ID: <87wpxunjc7.wl-ysato@users.sourceforge.jp> References: <55AD5265.5070109@roeck-us.net> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail2.asahi-net.or.jp ([202.224.39.198]:58919 "EHLO mail2.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbbGUF5r convert rfc822-to-8bit (ORCPT ); Tue, 21 Jul 2015 01:57:47 -0400 In-Reply-To: <55AD5265.5070109@roeck-us.net> Sender: linux-next-owner@vger.kernel.org List-ID: To: Guenter Roeck Cc: "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Arnd Bergmann , OGAWA Hirofumi , Jens Axboe , "linux-next@vger.kernel.org" On Tue, 21 Jul 2015 04:56:21 +0900, Guenter Roeck wrote: >=20 > Hi, >=20 > Commit 52b2512d507d ("asm-generic: {get,put}_user ptr argument evalua= te only 1 time") > causes the following compile error with various architectures (arc, a= rcv2, c6x, hexagon, > um, unicore32) in -next. >=20 > block/scsi_ioctl.c: In function =A1sg_scsi_ioctl=A2: > block/scsi_ioctl.c:436:2: error: invalid initializer > if (get_user(opcode, sic->data)) > ^ > make[1]: *** [block/scsi_ioctl.o] Error 1 >=20 > A possible fix would be to use &sic->data[0] instead, but I am not su= re if this change > in semantics of get_user would be acceptable. >=20 > Another failure due to the same commit is seen when building arc:axs1= 03_defconfig. >=20 > fs/fat/dir.c: In function =A1fat_ioctl_filldir=A2: > fs/fat/dir.c:752:43: error: invalid initializer > FAT_IOCTL_FILLDIR_FUNC(fat_ioctl_filldir, __fat_dirent) >=20 > This error is related to the put_user changes. No idea how to fix tha= t one. >=20 > Guenter Sorry. I misunderstand specification of get_user. I'll send fixed patch. --=20 Yoshinori Sato