* Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time"
@ 2015-07-20 19:56 Guenter Roeck
2015-07-21 5:57 ` Yoshinori Sato
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2015-07-20 19:56 UTC (permalink / raw)
To: Yoshinori Sato
Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven, Arnd Bergmann,
OGAWA Hirofumi, Jens Axboe, linux-next@vger.kernel.org
Hi,
Commit 52b2512d507d ("asm-generic: {get,put}_user ptr argument evaluate only 1 time")
causes the following compile error with various architectures (arc, arcv2, c6x, hexagon,
um, unicore32) in -next.
block/scsi_ioctl.c: In function ‘sg_scsi_ioctl’:
block/scsi_ioctl.c:436:2: error: invalid initializer
if (get_user(opcode, sic->data))
^
make[1]: *** [block/scsi_ioctl.o] Error 1
A possible fix would be to use &sic->data[0] instead, but I am not sure if this change
in semantics of get_user would be acceptable.
Another failure due to the same commit is seen when building arc:axs103_defconfig.
fs/fat/dir.c: In function ‘fat_ioctl_filldir’:
fs/fat/dir.c:752:43: error: invalid initializer
FAT_IOCTL_FILLDIR_FUNC(fat_ioctl_filldir, __fat_dirent)
This error is related to the put_user changes. No idea how to fix that one.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time"
2015-07-20 19:56 Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time" Guenter Roeck
@ 2015-07-21 5:57 ` Yoshinori Sato
0 siblings, 0 replies; 2+ messages in thread
From: Yoshinori Sato @ 2015-07-21 5:57 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven, Arnd Bergmann,
OGAWA Hirofumi, Jens Axboe, linux-next@vger.kernel.org
On Tue, 21 Jul 2015 04:56:21 +0900,
Guenter Roeck wrote:
>
> Hi,
>
> Commit 52b2512d507d ("asm-generic: {get,put}_user ptr argument evaluate only 1 time")
> causes the following compile error with various architectures (arc, arcv2, c6x, hexagon,
> um, unicore32) in -next.
>
> block/scsi_ioctl.c: In function ‘sg_scsi_ioctl’:
> block/scsi_ioctl.c:436:2: error: invalid initializer
> if (get_user(opcode, sic->data))
> ^
> make[1]: *** [block/scsi_ioctl.o] Error 1
>
> A possible fix would be to use &sic->data[0] instead, but I am not sure if this change
> in semantics of get_user would be acceptable.
>
> Another failure due to the same commit is seen when building arc:axs103_defconfig.
>
> fs/fat/dir.c: In function ‘fat_ioctl_filldir’:
> fs/fat/dir.c:752:43: error: invalid initializer
> FAT_IOCTL_FILLDIR_FUNC(fat_ioctl_filldir, __fat_dirent)
>
> This error is related to the put_user changes. No idea how to fix that one.
>
> Guenter
Sorry. I misunderstand specification of get_user.
I'll send fixed patch.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-21 5:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 19:56 Build failures in -next due to commit "asm-generic: {get,put}_user ptr argument evaluate only 1 time" Guenter Roeck
2015-07-21 5:57 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).