From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? Date: Wed, 22 Oct 2008 17:06:02 +0200 Message-ID: <87y70gk6ud.fsf@saeurebad.de> References: <20081017165738.GA20818@infradead.org> <20081017203710.GA27187@infradead.org> <20081017135510.7127c4e7@infradead.org> <20081020163327.GA15651@infradead.org> <20081020223549.GA21152@disturbed> <20081022075838.GK18495@disturbed> <20081022082550.GM18495@disturbed> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20081022082550.GM18495@disturbed> (Dave Chinner's message of "Wed, 22 Oct 2008 19:25:50 +1100") Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com To: Alexander Beregalov Cc: lachlan@sgi.com, Christoph Hellwig , Arjan van de Ven , xfs@oss.sgi.com, linux-next@vger.kernel.org, LKML List-Id: linux-next.vger.kernel.org Dave Chinner writes: > On Wed, Oct 22, 2008 at 06:58:38PM +1100, Dave Chinner wrote: >> On Tue, Oct 21, 2008 at 03:42:16PM +0400, Alexander Beregalov wrote: >> > Bisected to: >> > dd509097cb0b76d3836385f80d6b2d6fd3b97757 is first bad commit >> > commit dd509097cb0b76d3836385f80d6b2d6fd3b97757 >> > Author: Lachlan McIlroy >> > Date: Mon Sep 29 14:56:40 2008 +1000 >> > >> > [XFS] Unlock inode before calling xfs_idestroy() >> > >> > Lock debugging reported the ilock was being destroyed without being >> > unlocked. We don't need to lock the inode until we are going to insert it >> > into the radix tree. >> >> Ah, OK, I see the problem, though I don't understand why I'm not >> seeing the might_sleep() triggering all the time given that I always >> build with: >> >> $ grep SLEEP .config >> CONFIG_DEBUG_SPINLOCK_SLEEP=y >> >> Basically the above commit moved xfs_ilock() inside >> radix_tree_preload()/radix_tree_preload_end(), which means we are >> taking a rwsem() while we have an elevated preempt count. I'll >> get a patch out to fix it. > > Patch below (against the xfs master/linux-next branch) should fix the > regression. I've just started QA on it. Can you please check that > it works for you, Alexander? Ran into the same problem, the fix worked for me. Thank you. Hannes