From: Rusty Russell <rusty@rustcorp.com.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: linux-next: build failure after merge of the virtio tree
Date: Wed, 18 Mar 2015 18:04:11 +1030 [thread overview]
Message-ID: <87zj7alpxo.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20150318124734.629c0954@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi Rusty,
>
> After merging the virtio tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/virtio/virtio_mmio.c:250:12: error: redefinition of 'vm_generation'
> static u32 vm_generation(struct virtio_device *vdev)
> ^
> drivers/virtio/virtio_mmio.c:240:12: note: previous definition of 'vm_generation' was here
> static u32 vm_generation(struct virtio_device *vdev)
> ^
>
> Caused by the bad merge of commits 87e7bf1450c9 ("virtio_mmio:
> generation support") from Linus' tree and cf02b2c2d1a1 ("virtio_mmio:
> generation support") from the virtio tree.
>
> I fixed it up by removing the second version of that function.
>
> Could the virtio tree should be cleaned up to match what was sent to
> Linus, please?
Sorry, I clearly missed the failed push to virtio-next after I rebased a
fix.
Fixed now; I've modified my for-linus script to push to korg first
(which should be a noop).
Thanks,
Rusty.
next prev parent reply other threads:[~2015-03-18 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 1:47 linux-next: build failure after merge of the virtio tree Stephen Rothwell
2015-03-18 7:34 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-10 2:37 Stephen Rothwell
2012-12-10 22:41 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zj7alpxo.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).