Re: linux-next20240208: tg3 driver nw interfaces not getting configured

Andrew Lunn
2024-02-09T13:39:59Z

> Could you please test whether the following fixes the issue for you?
>
> The uninitialized struct ethtool_keee causes the bug because
> mii_eee_cap1_mod_linkmode_t() leaves unknown bits as-is.
>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 50f674031..7d0a2f5f3 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -4616,7 +4616,7 @@ static int tg3_init_5401phy_dsp(struct tg3 *tp)
>
> static bool tg3_phy_eee_config_ok(struct tg3 *tp)
> {
> - struct ethtool_keee eee;
> + struct ethtool_keee eee = {};

Nice catch.

Please add my Reviewed-by, if you have not already sent the real
patch.

Andrew