From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "Naresh Kamboju" <naresh.kamboju@linaro.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-next <linux-next@vger.kernel.org>,
lkft-triage@lists.linaro.org,
clang-built-linux <llvm@lists.linux.dev>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
Netdev <netdev@vger.kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Anders Roxell" <anders.roxell@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
maxime.chevallier@bootlin.com,
"Simon Horman" <simon.horman@corigine.com>
Subject: Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy
Date: Tue, 06 Jun 2023 12:21:19 +0200 [thread overview]
Message-ID: <8db9886f-e24f-44ee-8f8a-880dc3e4bf75@app.fastmail.com> (raw)
In-Reply-To: <CAMuHMdUH2Grrv6842YWXHDmd+O3iHdwqTVjYf8f1nbVRzGA+6w@mail.gmail.com>
On Tue, Jun 6, 2023, at 11:28, Geert Uytterhoeven wrote:
> On Tue, Jun 6, 2023 at 11:16 AM Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote:
>>
>> This won't work when PCS_LYNX is a loadable module and
>> STMMAC is built-in. I think we should just select PCS_LYNX
>
> Oops, you're right, forgot about that case.
> What about using IS_REACHABLE() instead?
> No, that won't work either, as DWMAC_SOCFPGA can be modular,
> with STMMAC builtin.
It would work because of the 'select PCS_LYNX' below DWMAC_SOCFPGA,
but I think that's too fragile and would easily break when another
dwmac front-end starts using PCS_LYNX without have the same select
statement. I think we should always avoid IS_REACHABLE().
Arnd
next prev parent reply other threads:[~2023-06-06 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:47 arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy Naresh Kamboju
2023-06-06 8:53 ` Naresh Kamboju
2023-06-06 9:01 ` Geert Uytterhoeven
2023-06-06 9:15 ` Arnd Bergmann
2023-06-06 9:28 ` Geert Uytterhoeven
2023-06-06 10:21 ` Arnd Bergmann [this message]
2023-06-06 10:31 ` Geert Uytterhoeven
2023-06-06 10:34 ` Arnd Bergmann
2023-06-07 13:27 ` Aithal, Srikanth
2023-06-07 13:41 ` Russell King (Oracle)
2023-06-07 13:59 ` Arnd Bergmann
2023-06-09 5:22 ` Aithal, Srikanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8db9886f-e24f-44ee-8f8a-880dc3e4bf75@app.fastmail.com \
--to=arnd@arndb.de \
--cc=anders.roxell@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox