From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F0CC7EE2C for ; Tue, 6 Jun 2023 10:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234654AbjFFKVn (ORCPT ); Tue, 6 Jun 2023 06:21:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235310AbjFFKVm (ORCPT ); Tue, 6 Jun 2023 06:21:42 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D28C7E6B; Tue, 6 Jun 2023 03:21:40 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 24A315C00E7; Tue, 6 Jun 2023 06:21:40 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 06 Jun 2023 06:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686046900; x=1686133300; bh=L3ruZsoNMC24z4nGykitqEHJTk2DsiwNv4s +KpsYVhY=; b=cQOuzlDf954AAyZ3fzxsKHPzmBWUkFvc3RXIqqWBI/wrO4YMxnv J7qNOoaOPr5wV1oqdJM/llje3mIq8KRspBJaVxERBS+b2+rw0Oj4MMyT/KLObsTN QS63NRHm3R3LLzKIJR0ZVbpVsx3iSDfhdF8GKCA1VjjwN3rmqW68+Crd1Gtxz+9G q1QSANnaa0GblJdG1jIvdH5sDSwrVyNtE1k90zB95g3whfUa8qEOP66nS6mIkqO+ e7G6rPvOZM6LG0TnLHGG0WaqJh6XTs4on4GgLHCqC5IyUGUc5DjDhmeIwuMvbF0C FejzDhLWxkREtP9iNonG7sx8JOsFloPwhFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686046900; x=1686133300; bh=L3ruZsoNMC24z4nGykitqEHJTk2DsiwNv4s +KpsYVhY=; b=dxRD7YCXiG0YFmIuM4qLgZDdJdSPLTjqo34GjbSDf31hOGGimjM gMLF0S4VyAiJd0YI0Kb9iNLcRu2H0rIuD1OuRI0pbQFof2/cIURVaoXRce+L3Nos Exe+pyH1a9Nc3Gu6dCL+qXvOgmlLjoVrs8gFC0PE6LiunqjO1NLUzimxYP5EgyJs 9IDTHHK4w/M1ztSSAY6xUvPeoRPCQ0zcHb7YRW/5Wg1Rg2eaIveJNouw+Heli7oY Efwk25hRdjDZWfPGtiRiKS8+GE9wSWLAkLPLR9dNrIP4RkEKtMDf4NrMxQGBDs7q xXhBna5hbt/HA/LUaotTU5qzycoMHFQ/a1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtuddgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeegfeejhedvledvffeijeeijeeivddvhfeliedvleevheejleetgedukedt gfejveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9405FB60086; Tue, 6 Jun 2023 06:21:39 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13 Mime-Version: 1.0 Message-Id: <8db9886f-e24f-44ee-8f8a-880dc3e4bf75@app.fastmail.com> In-Reply-To: References: <11bd37e9-c62e-46ba-9456-8e3b353df28f@app.fastmail.com> Date: Tue, 06 Jun 2023 12:21:19 +0200 From: "Arnd Bergmann" To: "Geert Uytterhoeven" Cc: "Naresh Kamboju" , "open list" , linux-next , lkft-triage@lists.linaro.org, clang-built-linux , Linux-Renesas , "Linux ARM" , Netdev , "Nathan Chancellor" , "Nick Desaulniers" , "Anders Roxell" , "Geert Uytterhoeven" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Maxime Coquelin" , maxime.chevallier@bootlin.com, "Simon Horman" Subject: Re: arm: shmobile_defconfig: ld.lld: error: undefined symbol: lynx_pcs_destroy Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Tue, Jun 6, 2023, at 11:28, Geert Uytterhoeven wrote: > On Tue, Jun 6, 2023 at 11:16=E2=80=AFAM Arnd Bergmann = wrote: >> On Tue, Jun 6, 2023, at 11:01, Geert Uytterhoeven wrote: >> >> This won't work when PCS_LYNX is a loadable module and >> STMMAC is built-in. I think we should just select PCS_LYNX > > Oops, you're right, forgot about that case. > What about using IS_REACHABLE() instead? > No, that won't work either, as DWMAC_SOCFPGA can be modular, > with STMMAC builtin. It would work because of the 'select PCS_LYNX' below DWMAC_SOCFPGA, but I think that's too fragile and would easily break when another dwmac front-end starts using PCS_LYNX without have the same select statement. I think we should always avoid IS_REACHABLE(). Arnd