Re: [PATCH] gpiolib: fix compiling when CONFIG_GPIO_CDEV_V1 is not defined

Andy Shevchenko
2022-12-02T14:33:23Z

On Fri, Dec 02, 2022 at 04:30:33PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 02, 2022 at 03:04:54PM +0100, Nick Hainke wrote:

...

> > drivers/gpio/gpiolib-cdev.c:1468:16: error: implicit declaration of
> > function 'call_ioctl_locked' [-Werror=implicit-function-declaration]

> > drivers/gpio/gpiolib-cdev.c:1503:16: error: implicit declaration of
> > function 'call_poll_locked'; did you mean 'wake_up_all_locked'?
> > [-Werror=implicit-function-declaration]

> > drivers/gpio/gpiolib-cdev.c:1566:16: error: implicit declaration of
> > function 'call_read_locked'; did you mean 'xa_head_locked'?
> > [-Werror=implicit-function-declaration]

> Above is a bit too noisy for the commit message. It can be trimmed 3x times.

To be precise leave only the above and make them as is (i.e. unwrapped even
if they are so long), because it's a citation from the compiler.

--
With Best Regards,
Andy Shevchenko