RE: [PATCH v2 11/12] scsi: ufs: Simplify transfer request header initialization

Kumar, Udit
2023-08-02T16:44:52Z

Thanks Bart

>
>On 8/2/23 04:25, Kumar, Udit wrote:
>> While building next-20230801 for ARM64 architecture,
>>
>> this patch is giving compilation error
>>
>> In function ‘ufshcd_check_header_layout’,
>>     inlined from ‘ufshcd_core_init’ at drivers/ufs/core/ufshcd.c:10629:2:
>> ././include/linux/compiler_types.h:397:38: error: call to
>> ‘__compiletime_assert_554’ declared with attribute error: BUILD_BUG_ON
>> failed: ((u8 *)&(struct request_desc_header){ .enable_crypto = 1})[2]
>> !=
>> 0x80
>>   397 |  _compiletime_assert(condition, msg, __compiletime_assert_,
>> __COUNTER__)
>>
>>
>> compiler information
>>
>> wget
>> https://developer.arm.com/-/media/Files/downloads/gnu-a/9.2-2019.12/bi
>> nrel/gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz
>
>Does this patch help:
>https://lore.kernel.org/linux-scsi/20230801232204.1481902-1-
>bvanassche@acm.org/?

Yes , build works for me with this patch.
You just skipped based upon compiler version but
what about checks you want to do in this function.

>Thanks,
>
>Bart.