public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Chen Wang" <unicorn_wang@outlook.com>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>,
	"Inochi Amaoto" <inochiama@outlook.com>,
	"Olof Johansson" <olof@lixom.net>
Cc: ARM <linux-arm-kernel@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>
Subject: Re: linux-next: duplicate patches in the sophgo tree
Date: Fri, 06 Sep 2024 06:54:10 +0000	[thread overview]
Message-ID: <9b83c044-5f22-499e-94a2-1c81f41cb620@app.fastmail.com> (raw)
In-Reply-To: <MA0P287MB282200D15F3A93CE187FA66FFE9E2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>

On Fri, Sep 6, 2024, at 03:24, Chen Wang wrote:
> Hi,Stephen,
>
> The arm-soc tree contains these patches is due to I submited a PR to 
> Arnd and he merged this today.
>
> And for the sophgo/for-next branch, it does contains these patches. I 
> created the PR branch(sophgo/riscv-sophgo-dt-for-next) and cherry-picked 
> these patches from sophgo/for-next and submited the PR. I see the 
> commits in arm-soc are the same as that from 
> sophgo/riscv-sophgo-dt-for-next, but they are different against the 
> commit ids from sophgo/for-next due to cherry-pick operation.
>
> So my question is, do we need to make sure commit id the same between PR 
> branch and sophgo/for-next branch?

It certainly makes things easier for everyone if you have the
same commit IDs, yes. Aside from tripping Stephen's sanity checks,
having rebased commits in your tree also means that the branch that
gets tested is different from the one that gets merged.

If you have multiple branches that you want to be in linux-next but
get merged through different upstream trees, your for-next branch
would normally just be a merge of those rather than a cherry-pick.

[Side note: you should also ensure that each of those branches
individually works correctly, i.e. it may add features that only work
when combined with the other branches, but it never introduces
regressions when merged without the other ones.]

      Arnd

  parent reply	other threads:[~2024-09-06  6:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  2:04 linux-next: duplicate patches in the sophgo tree Stephen Rothwell
2024-09-06  3:24 ` Chen Wang
2024-09-06  3:40   ` Stephen Rothwell
2024-09-06  5:34     ` Chen Wang
2024-09-06  6:54   ` Arnd Bergmann [this message]
2024-09-06  8:12     ` Chen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b83c044-5f22-499e-94a2-1c81f41cb620@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=inochiama@outlook.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sfr@canb.auug.org.au \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox