From: Catalin Marinas <catalin.marinas@arm.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
randy.dunlap@oracle.com, linux-kbuild@vger.kernel.org,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
xiyou.wangcong@gmail.com,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] Revert "kconfig: Temporarily disable dependency warnings"
Date: Fri, 26 Nov 2010 14:50:10 +0000 [thread overview]
Message-ID: <AANLkTi=jMWL7z=30AnJ0An2HtygserxDbkzagv5_hU1h@mail.gmail.com> (raw)
In-Reply-To: <4CEFB731.4050307@suse.cz>
On 26 November 2010 13:33, Michal Marek <mmarek@suse.cz> wrote:
> On 26.11.2010 13:33, Catalin Marinas wrote:
>> On 25 November 2010 18:09, Arnaud Lacombe <lacombar@gmail.com> wrote:
>>> On Thu, Nov 25, 2010 at 12:43 PM, Catalin Marinas
>>> <catalin.marinas@arm.com> wrote:
>>>> Now, commenting on your patches, you added a new statement, 'visible
>>>> if...' for menus. Can we not change it to something like:
>>>>
>>>> -menu "I2C Algorithms"
>>>> - depends on !I2C_HELPER_AUTO
>>>> +menu "I2C Algorithms" if !I2C_HELPER_AUTO
>>>>
>>> no because if_expr are translated internally in term of dependency,
>>> which we don't want.
>>
>> That's correct but I was wondering whether we could change this kind
>> of 'if' to a visibility attribute or a weaker dependency and avoid
>> 'select' warnings. This way we wouldn't introduce new keywords to the
>> kconfig language.
>
> I quite like the "visible if" notation because it makes it explicit that
> it only affects the display of the menu and does not add any dependency
> to the data.
That's fine by me. If you like this feature then it could get upstream :)
--
Catalin
next prev parent reply other threads:[~2010-11-26 14:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 0:44 linux-next: build warnings after merge of the kbuild-current tree Stephen Rothwell
2010-10-06 11:13 ` Michal Marek
2010-10-06 11:42 ` Catalin Marinas
2010-10-08 14:51 ` Michal Marek
2010-10-08 15:03 ` Américo Wang
2010-10-08 15:05 ` Michal Marek
2010-10-09 21:45 ` [PATCH] kconfig: Temporarily disable dependency warnings Michal Marek
2010-10-11 15:23 ` Catalin Marinas
2010-10-11 21:46 ` Michal Marek
2010-10-11 21:59 ` Randy Dunlap
2010-10-12 13:19 ` [PATCH] Revert "kconfig: Temporarily disable dependency warnings" Michal Marek
2010-10-29 0:37 ` Stephen Rothwell
2010-11-22 0:48 ` Stephen Rothwell
2010-11-22 1:44 ` Randy Dunlap
2010-11-22 1:58 ` Arnaud Lacombe
2010-11-22 2:09 ` Randy Dunlap
2010-11-22 2:17 ` Arnaud Lacombe
2010-11-22 2:57 ` Stephen Rothwell
2010-11-22 13:26 ` Mauro Carvalho Chehab
2010-11-25 17:16 ` Arnaud Lacombe
2010-11-25 17:43 ` Catalin Marinas
2010-11-25 18:09 ` Arnaud Lacombe
2010-11-26 12:33 ` Catalin Marinas
2010-11-26 13:33 ` Michal Marek
2010-11-26 14:50 ` Catalin Marinas [this message]
2010-11-25 19:26 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=jMWL7z=30AnJ0An2HtygserxDbkzagv5_hU1h@mail.gmail.com' \
--to=catalin.marinas@arm.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mmarek@suse.cz \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).