From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI Date: Sat, 9 Apr 2011 13:34:49 +0200 Message-ID: References: <20110408083215.6b3b0bfe.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:38306 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752598Ab1DILev convert rfc822-to-8bit (ORCPT ); Sat, 9 Apr 2011 07:34:51 -0400 In-Reply-To: <20110408083215.6b3b0bfe.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Stephen Rothwell , Baruch Siach , linux-i2c@vger.kernel.org, linux-next@vger.kernel.org, LKML , khali@linux-fr.org, ben-linux@fluff.org On Fri, Apr 8, 2011 at 17:32, Randy Dunlap wr= ote: > From: Randy Dunlap > > i2c-designware-pcidrv is a PCI driver and should depend on PCI. > Fixes these build errors: > > drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit decla= ration of function 'pci_request_region' > drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit decla= ration of function 'pci_release_region' > > Signed-off-by: Randy Dunlap > Cc: Baruch Siach > --- > =C2=A0drivers/i2c/busses/Kconfig | =C2=A0 =C2=A01 + > =C2=A01 file changed, 1 insertion(+) > > Does anybody merge i2c patches??? Yes please, it's been there since Mar 17, reported several times, and p= robably masking other build failures. > --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig > +++ linux-next-20110316/drivers/i2c/busses/Kconfig > @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM > > =C2=A0config I2C_DESIGNWARE_PCI > =C2=A0 =C2=A0 =C2=A0 =C2=A0tristate "Synopsys DesignWare PCI" > + =C2=A0 =C2=A0 =C2=A0 depends on PCI > =C2=A0 =C2=A0 =C2=A0 =C2=A0help > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0If you say yes to this option, supp= ort will be included for the > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Synopsys DesignWare I2C adapter. On= ly master mode is supported. Gr{oetje,eeting}s, =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-= m68k.org In personal conversations with technical people, I call myself a hacker= =2E But when I'm talking to journalists I just say "programmer" or something li= ke that. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds