From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arvind R Subject: Re: linux-next: Tree for April 21 (i82975x_edac) Date: Sat, 23 Apr 2011 13:51:04 +0530 Message-ID: References: <20110421132045.5af1b953.sfr@canb.auug.org.au> <20110421085124.4a44d048.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-iy0-f174.google.com ([209.85.210.174]:44342 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190Ab1DWIVF convert rfc822-to-8bit (ORCPT ); Sat, 23 Apr 2011 04:21:05 -0400 In-Reply-To: <20110421085124.4a44d048.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Stephen Rothwell , Ranganathan Desikan , linux-next@vger.kernel.org, LKML , bluesmoke-devel@lists.sourceforge.net, linux-edac@vger.kernel.org On Thu, Apr 21, 2011 at 9:21 PM, Randy Dunlap = wrote: > On Thu, 21 Apr 2011 13:20:45 +1000 Stephen Rothwell wrote: > >> Changes since 20110420: > > > on i386: > > drivers/edac/i82975x_edac.c:298: warning: integer constant is too lar= ge for 'unsigned long' type > > which is: > > =A0 =A0 =A0 =A0if (info->xeap & 1) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0page |=3D 0x100000000ul; <<<<<<<<<<<<<= << > > but page is unsigned long (32 bits), while 0x100000000ul is more than= 32 bits, > so that line isn't setting a bit in . =A0Is it a bug, or this d= river isn't > applicable to X86_32, or what? > would defining page variable to unsigned long long solve it for x86_32? That would still not fix the wrong error-info reported by the driver - = this is fixed by the patch-set titled '[RFC PATCH 2.6.37 0/4] i3000_edac : merg= e i82975x support' dated 2011-02-14 in the linux-edac archives. Please advise on getting the patch into main-stream. The I3000 is a re-= labeled i82975x (or vice-versa). Hence the patch-set to merge the drivers. If s= eparate i82975x driver is needed - I can provide the patch. The reported bug is= not present in the merge-patched driver. Thanks, Arvind.