* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
@ 2012-07-17 9:47 Sedat Dilek
2012-07-17 10:21 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2012-07-17 9:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Linus Walleij, Samuel Ortiz, linux-arm-kernel
On Tue, Jul 17, 2012 at 7:41 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Changes since 20120716:
>
> The vfs tree lost its build failure.
>
> The l2-mtd tree gained a conflict against the mtd tree.
>
> The battery tree tree lost its build failure.
>
> The regulator tree gained conflicts against the mfd tree.
>
> The tty tree lost its build failure but gained another, so I used the
> version from next-20120712.
>
> I have still reverted 3 commits from the signal tree at the request of the
> arm maintainer.
>
> The akpm tree lost a few patches that turned up elsewhere.
>
>From my today's build-log on a Ubuntu/precise AMD64 host:
[...]
LD drivers/video/built-in.o
LD drivers/built-in.o
LINK vmlinux
LD vmlinux.o
MODPOST vmlinux.o
GEN .version
CHK include/generated/compile.h
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `ab3100_probe':
ab3100-core.c:(.devinit.text+0xbf97): undefined reference to
`rand_initialize_irq'
make[2]: *** [vmlinux] Error 1
make[1]: *** [deb-pkg] Error 2
make: *** [deb-pkg] Error 2
MFD / AB3100 kernel-config settings:
CONFIG_AB3100_CORE=y
CONFIG_AB3100_OTP=m
CONFIG_REGULATOR_AB3100=m
CONFIG_RTC_DRV_AB3100=m
If you need further informations, please let me know.
- Sedat -
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
2012-07-17 9:47 linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq') Sedat Dilek
@ 2012-07-17 10:21 ` Sedat Dilek
2012-07-17 10:39 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2012-07-17 10:21 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, LKML, Linus Walleij, Samuel Ortiz, linux-arm-kernel,
Theodore Ts'o
On Tue, Jul 17, 2012 at 11:47 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Tue, Jul 17, 2012 at 7:41 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> Hi all,
>>
>> Changes since 20120716:
>>
>> The vfs tree lost its build failure.
>>
>> The l2-mtd tree gained a conflict against the mtd tree.
>>
>> The battery tree tree lost its build failure.
>>
>> The regulator tree gained conflicts against the mfd tree.
>>
>> The tty tree lost its build failure but gained another, so I used the
>> version from next-20120712.
>>
>> I have still reverted 3 commits from the signal tree at the request of the
>> arm maintainer.
>>
>> The akpm tree lost a few patches that turned up elsewhere.
>>
>
> From my today's build-log on a Ubuntu/precise AMD64 host:
> [...]
> LD drivers/video/built-in.o
> LD drivers/built-in.o
> LINK vmlinux
> LD vmlinux.o
> MODPOST vmlinux.o
> GEN .version
> CHK include/generated/compile.h
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `ab3100_probe':
> ab3100-core.c:(.devinit.text+0xbf97): undefined reference to
> `rand_initialize_irq'
> make[2]: *** [vmlinux] Error 1
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
>
> MFD / AB3100 kernel-config settings:
>
> CONFIG_AB3100_CORE=y
> CONFIG_AB3100_OTP=m
> CONFIG_REGULATOR_AB3100=m
> CONFIG_RTC_DRV_AB3100=m
>
> If you need further informations, please let me know.
>
> - Sedat -
[ CC Ted (new random maintainer) ]
Is this due to this change?
>From 946672f548682905d8ecdab33bb6e2c705418505 Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso@mit.edu>
Date: Sat, 14 Jul 2012 20:27:52 -0400
Subject: [PATCH] random: remove rand_initialize_irq()
With the new interrupt sampling system, we are no longer using the
timer_rand_state structure in the irq descriptor, so we can stop
initializing it now.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu
...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
drivers/mfd/ab3100-core.c:939: rand_initialize_irq(client->irq);
...but why has random.h still this...?
include/linux/random.h:51:extern void rand_initialize_irq(int irq);
Just thinking "loud"...
- Sedat -
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
2012-07-17 10:21 ` Sedat Dilek
@ 2012-07-17 10:39 ` Sedat Dilek
2012-07-17 18:40 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2012-07-17 10:39 UTC (permalink / raw)
To: Theodore Ts'o
Cc: linux-next, LKML, Linus Walleij, Samuel Ortiz, linux-arm-kernel,
Stephen Rothwell
[-- Attachment #1: Type: text/plain, Size: 2476 bytes --]
On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Tue, Jul 17, 2012 at 11:47 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> On Tue, Jul 17, 2012 at 7:41 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>> Hi all,
>>>
>>> Changes since 20120716:
>>>
>>> The vfs tree lost its build failure.
>>>
>>> The l2-mtd tree gained a conflict against the mtd tree.
>>>
>>> The battery tree tree lost its build failure.
>>>
>>> The regulator tree gained conflicts against the mfd tree.
>>>
>>> The tty tree lost its build failure but gained another, so I used the
>>> version from next-20120712.
>>>
>>> I have still reverted 3 commits from the signal tree at the request of the
>>> arm maintainer.
>>>
>>> The akpm tree lost a few patches that turned up elsewhere.
>>>
>>
>> From my today's build-log on a Ubuntu/precise AMD64 host:
>> [...]
>> LD drivers/video/built-in.o
>> LD drivers/built-in.o
>> LINK vmlinux
>> LD vmlinux.o
>> MODPOST vmlinux.o
>> GEN .version
>> CHK include/generated/compile.h
>> UPD include/generated/compile.h
>> CC init/version.o
>> LD init/built-in.o
>> drivers/built-in.o: In function `ab3100_probe':
>> ab3100-core.c:(.devinit.text+0xbf97): undefined reference to
>> `rand_initialize_irq'
>> make[2]: *** [vmlinux] Error 1
>> make[1]: *** [deb-pkg] Error 2
>> make: *** [deb-pkg] Error 2
>>
>> MFD / AB3100 kernel-config settings:
>>
>> CONFIG_AB3100_CORE=y
>> CONFIG_AB3100_OTP=m
>> CONFIG_REGULATOR_AB3100=m
>> CONFIG_RTC_DRV_AB3100=m
>>
>> If you need further informations, please let me know.
>>
>> - Sedat -
>
> [ CC Ted (new random maintainer) ]
>
> Is this due to this change?
>
> From 946672f548682905d8ecdab33bb6e2c705418505 Mon Sep 17 00:00:00 2001
> From: Theodore Ts'o <tytso@mit.edu>
> Date: Sat, 14 Jul 2012 20:27:52 -0400
> Subject: [PATCH] random: remove rand_initialize_irq()
>
> With the new interrupt sampling system, we are no longer using the
> timer_rand_state structure in the irq descriptor, so we can stop
> initializing it now.
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu
>
> ...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
>
> drivers/mfd/ab3100-core.c:939: rand_initialize_irq(client->irq);
>
> ...but why has random.h still this...?
>
> include/linux/random.h:51:extern void rand_initialize_irq(int irq);
>
> Just thinking "loud"...
>
> - Sedat -
Is this attached patch OK, Ted?
- Sedat -
[-- Attachment #2: 0001-random-remove-remaining-relicts-of-rand_initialize_i.patch --]
[-- Type: application/octet-stream, Size: 2213 bytes --]
From 49d01ce17422eae1bd56531a6baaa6dad1fb592f Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@gmail.com>
Date: Tue, 17 Jul 2012 12:30:18 +0200
Subject: [PATCH] random: remove remaining relicts of rand_initialize_irq()
rand_initialize_irq() was removed here:
commit 946672f548682905d8ecdab33bb6e2c705418505
"random: remove rand_initialize_irq()"
AB3100 mfd-driver is the only driver using it and breaks with
these error-messaged in linux-next (next-20120717):
...
drivers/built-in.o: In function `ab3100_probe':
ab3100-core.c:(.devinit.text+0xbf97): undefined reference to `rand_initialize_irq'
Fix this and remove all remaining relicts of rand_initialize_irq().
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
arch/ia64/kernel/irq_ia64.c | 1 -
drivers/mfd/ab3100-core.c | 2 --
include/linux/random.h | 2 --
3 files changed, 5 deletions(-)
diff --git a/arch/ia64/kernel/irq_ia64.c b/arch/ia64/kernel/irq_ia64.c
index 5c3e088..1034884 100644
--- a/arch/ia64/kernel/irq_ia64.c
+++ b/arch/ia64/kernel/irq_ia64.c
@@ -23,7 +23,6 @@
#include <linux/ioport.h>
#include <linux/kernel_stat.h>
#include <linux/ptrace.h>
-#include <linux/random.h> /* for rand_initialize_irq() */
#include <linux/signal.h>
#include <linux/smp.h>
#include <linux/threads.h>
diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c
index e799050..78fca29 100644
--- a/drivers/mfd/ab3100-core.c
+++ b/drivers/mfd/ab3100-core.c
@@ -934,8 +934,6 @@ static int __devinit ab3100_probe(struct i2c_client *client,
IRQF_ONESHOT, "ab3100-core", ab3100);
if (err)
goto exit_no_irq;
- /* This real unpredictable IRQ is of course sampled for entropy */
- rand_initialize_irq(client->irq);
err = abx500_register_ops(&client->dev, &ab3100_ops);
if (err)
diff --git a/include/linux/random.h b/include/linux/random.h
index 29e217a..ac621ce 100644
--- a/include/linux/random.h
+++ b/include/linux/random.h
@@ -48,8 +48,6 @@ struct rnd_state {
#ifdef __KERNEL__
-extern void rand_initialize_irq(int irq);
-
extern void add_device_randomness(const void *, unsigned int);
extern void add_input_randomness(unsigned int type, unsigned int code,
unsigned int value);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
2012-07-17 10:39 ` Sedat Dilek
@ 2012-07-17 18:40 ` Linus Walleij
2012-07-18 17:54 ` Sedat Dilek
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2012-07-17 18:40 UTC (permalink / raw)
To: sedat.dilek
Cc: Theodore Ts'o, linux-next, LKML, Linus Walleij, Samuel Ortiz,
linux-arm-kernel, Stephen Rothwell
On Tue, Jul 17, 2012 at 12:39 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> ...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
>>
>> drivers/mfd/ab3100-core.c:939: rand_initialize_irq(client->irq);
>>
>> ...but why has random.h still this...?
>>
>> include/linux/random.h:51:extern void rand_initialize_irq(int irq);
>>
>> Just thinking "loud"...
>>
>> - Sedat -
>
> Is this attached patch OK, Ted?
You're just deleting a line from the AB3100 driver, so I guess you're
regressing the system since that IRQ will no longer contribute
to the entropy pool?
How do we simultaneously make sure that this IRQ is still
contributing to the entropy?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
2012-07-17 18:40 ` Linus Walleij
@ 2012-07-18 17:54 ` Sedat Dilek
2012-07-23 19:10 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Sedat Dilek @ 2012-07-18 17:54 UTC (permalink / raw)
To: Linus Walleij
Cc: Theodore Ts'o, linux-next, LKML, Linus Walleij, Samuel Ortiz,
linux-arm-kernel, Stephen Rothwell
On Tue, Jul 17, 2012 at 8:40 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Jul 17, 2012 at 12:39 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> On Tue, Jul 17, 2012 at 12:21 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>> ...looks like AB3100 is the *only* driver still using rand_initialize_irq()...
>>>
>>> drivers/mfd/ab3100-core.c:939: rand_initialize_irq(client->irq);
>>>
>>> ...but why has random.h still this...?
>>>
>>> include/linux/random.h:51:extern void rand_initialize_irq(int irq);
>>>
>>> Just thinking "loud"...
>>>
>>> - Sedat -
>>
>> Is this attached patch OK, Ted?
>
> You're just deleting a line from the AB3100 driver, so I guess you're
> regressing the system since that IRQ will no longer contribute
> to the entropy pool?
>
> How do we simultaneously make sure that this IRQ is still
> contributing to the entropy?
>
For the sake of completeness:
* Ted explained in his answer in [1].
* Just FYI: [2] has these changes merged into the original commit.
- Sedat -
[1] http://marc.info/?l=linux-next&m=134256445707799&w=2
[2] http://git.kernel.org/?p=linux/kernel/git/tytso/random.git;a=commitdiff;h=627574db8b21c51217c683909458500916e64963
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq')
2012-07-18 17:54 ` Sedat Dilek
@ 2012-07-23 19:10 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2012-07-23 19:10 UTC (permalink / raw)
To: sedat.dilek
Cc: Theodore Ts'o, linux-next, LKML, Linus Walleij, Samuel Ortiz,
linux-arm-kernel, Stephen Rothwell
On Wed, Jul 18, 2012 at 7:54 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> For the sake of completeness:
> * Ted explained in his answer in [1].
> * Just FYI: [2] has these changes merged into the original commit.
Yep I read up on it and I'm all fine with it.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-07-23 19:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-17 9:47 linux-next: Tree for July 17 (mfd: AB3100 - ab3100_probe: undefined reference to `rand_initialize_irq') Sedat Dilek
2012-07-17 10:21 ` Sedat Dilek
2012-07-17 10:39 ` Sedat Dilek
2012-07-17 18:40 ` Linus Walleij
2012-07-18 17:54 ` Sedat Dilek
2012-07-23 19:10 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).