From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Leonidas S Barbosa <leosilva@linux.vnet.ibm.com>
Cc: linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
LKML <linux-kernel@vger.kernel.org>,
Paulo Smorigo <pfsmorigo@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug
Date: Fri, 21 Aug 2015 15:19:18 -0400 [thread overview]
Message-ID: <CAP=VYLr59L+1fi0UDjQPVmEOUbT-KnmpLY562mACHxsRqHEk3A@mail.gmail.com> (raw)
In-Reply-To: <20150814131218.GA11746@bluepex.com>
On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa
<leosilva@linux.vnet.ibm.com> wrote:
> AES-CTR is using a counter 8bytes-8bytes what miss match with
> kernel specs.
>
> In the previous code a vadduwm was done to increment counter.
> Replacing this for a vadduqm now considering both cases counter
> 8-8 bytes and full 16bytes.
Seems this breaks ppc allmodconfig:
drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm'
1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 is the first bad commit
commit 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0
Author: Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com>
Date: Fri Aug 14 10:12:22 2015 -0300
crypto: vmx - Fixing AES-CTR counter bug
http://kisskb.ellerman.id.au/kisskb/buildresult/12490159/
Paul.
--
>
> Signed-off-by: Leonidas S Barbosa <leosilva@linux.vnet.ibm.com>
> ---
> drivers/crypto/vmx/aes_ctr.c | 8 +++++++-
> drivers/crypto/vmx/aesp8-ppc.pl | 34 +++++++++++++++++-----------------
> 2 files changed, 24 insertions(+), 18 deletions(-)
>
>
next parent reply other threads:[~2015-08-21 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150814131218.GA11746@bluepex.com>
2015-08-21 19:19 ` Paul Gortmaker [this message]
2015-08-21 20:15 ` [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug Leonidas S Barbosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP=VYLr59L+1fi0UDjQPVmEOUbT-KnmpLY562mACHxsRqHEk3A@mail.gmail.com' \
--to=paul.gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=leosilva@linux.vnet.ibm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pfsmorigo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).