* Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug [not found] <20150814131218.GA11746@bluepex.com> @ 2015-08-21 19:19 ` Paul Gortmaker 2015-08-21 20:15 ` Leonidas S Barbosa 0 siblings, 1 reply; 2+ messages in thread From: Paul Gortmaker @ 2015-08-21 19:19 UTC (permalink / raw) To: Leonidas S Barbosa Cc: linux-crypto, Herbert Xu, LKML, Paulo Smorigo, David S. Miller, linux-next@vger.kernel.org On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa <leosilva@linux.vnet.ibm.com> wrote: > AES-CTR is using a counter 8bytes-8bytes what miss match with > kernel specs. > > In the previous code a vadduwm was done to increment counter. > Replacing this for a vadduqm now considering both cases counter > 8-8 bytes and full 16bytes. Seems this breaks ppc allmodconfig: drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm' 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 is the first bad commit commit 1d4aa0b4c1816e8ca92a6aadb0d8f6b43c56c0d0 Author: Leonidas Da Silva Barbosa <leosilva@linux.vnet.ibm.com> Date: Fri Aug 14 10:12:22 2015 -0300 crypto: vmx - Fixing AES-CTR counter bug http://kisskb.ellerman.id.au/kisskb/buildresult/12490159/ Paul. -- > > Signed-off-by: Leonidas S Barbosa <leosilva@linux.vnet.ibm.com> > --- > drivers/crypto/vmx/aes_ctr.c | 8 +++++++- > drivers/crypto/vmx/aesp8-ppc.pl | 34 +++++++++++++++++----------------- > 2 files changed, 24 insertions(+), 18 deletions(-) > > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug 2015-08-21 19:19 ` [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug Paul Gortmaker @ 2015-08-21 20:15 ` Leonidas S Barbosa 0 siblings, 0 replies; 2+ messages in thread From: Leonidas S Barbosa @ 2015-08-21 20:15 UTC (permalink / raw) To: Paul Gortmaker Cc: linux-crypto, Herbert Xu, LKML, Paulo Smorigo, David S. Miller, linux-next@vger.kernel.org On Fri, Aug 21, 2015 at 03:19:18PM -0400, Paul Gortmaker wrote: > On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa > <leosilva@linux.vnet.ibm.com> wrote: > > AES-CTR is using a counter 8bytes-8bytes what miss match with > > kernel specs. > > > > In the previous code a vadduwm was done to increment counter. > > Replacing this for a vadduqm now considering both cases counter > > 8-8 bytes and full 16bytes. > > Seems this breaks ppc allmodconfig: > > drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm' Thanks for report, I could not reproduce this issue, but I believe it's a opcode map error on ppc-xlate.pl. Sending a patch followed by this email you CCed. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-21 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150814131218.GA11746@bluepex.com>
2015-08-21 19:19 ` [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug Paul Gortmaker
2015-08-21 20:15 ` Leonidas S Barbosa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).