Section mismatch in drivers/usb/gadget/fotg210-udc.c

Section mismatch in drivers/usb/gadget/fotg210-udc.c

[Paul Gortmaker]

Hi guys,

This was seen on a linux-next (Jun18th tree) allmodconfig build:

WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe()
The variable fotg210_driver references
the function __init fotg210_udc_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Paul.

Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

Hi,

On Thu, Jun 20, 2013 at 01:53:13PM +0000, Yuan-Hsin Chen wrote:
> Because fotg210-udc is configured as a non-hotpluggable device,
> that makes sense to use module_platform_driver_probe() instead of
> module_platform_driver(). This also fixes the section mismatch issue.
> 
> Signed-off-by: Yuan-Hsin Chen <yhchen@faraday-tech.com>

I would rather see you remove __init annotation from your probe()
function. The reason being that it will users to bind/unbind the driver
through sysfs, which is pretty good for testing, at least.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] usb: gadget: fotg210-udc: Use module_platform_driver_probe macro

[Yuan-Hsin Chen]

Hi,


On Thu, Jun 20, 2013 at 8:16 PM, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> wrote:
>
> Hi,
>
> On Thu, Jun 20, 2013 at 01:53:13PM +0000, Yuan-Hsin Chen wrote:
> > Because fotg210-udc is configured as a non-hotpluggable device,
> > that makes sense to use module_platform_driver_probe() instead of
> > module_platform_driver(). This also fixes the section mismatch issue.
> >
> > Signed-off-by: Yuan-Hsin Chen <yhchen-w0jeGXs5+AWXmMXjJBpWqg@public.gmane.org>
>
> I would rather see you remove __init annotation from your probe()
> function. The reason being that it will users to bind/unbind the driver
> through sysfs, which is pretty good for testing, at least.

I see and will send a patch later. Thanks.

Yuan-Hsin

>
>
> --
> balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Section mismatch in drivers/usb/gadget/fotg210-udc.c

[Paul Gortmaker]

On Wed, Jun 19, 2013 at 4:06 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> Hi guys,
>
> This was seen on a linux-next (Jun18th tree) allmodconfig build:
>
> WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe()
> The variable fotg210_driver references
> the function __init fotg210_udc_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

Hi,

Wondering if this fell through the cracks?   I recall the fix being discussed,
but yet I'm still seeing the problem when I build today's linux-next, and the
merge window has already opened on Monday.

Paul.
--


>
> Paul.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Section mismatch in drivers/usb/gadget/fotg210-udc.c

[Paul Gortmaker]

On Wed, Jul 3, 2013 at 1:00 PM, Paul Gortmaker
<paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> wrote:
> On Wed, Jun 19, 2013 at 4:06 PM, Paul Gortmaker
> <paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> wrote:
>> Hi guys,
>>
>> This was seen on a linux-next (Jun18th tree) allmodconfig build:
>>
>> WARNING: drivers/usb/gadget/fotg210-udc.o(.data+0x0): Section mismatch in reference from the variable fotg210_driver to the function .init.text:fotg210_udc_probe()
>> The variable fotg210_driver references
>> the function __init fotg210_udc_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
>
> Hi,
>
> Wondering if this fell through the cracks?   I recall the fix being discussed,
> but yet I'm still seeing the problem when I build today's linux-next, and the
> merge window has already opened on Monday.

I guess Yuan-Hsin isn't even able to see these mails; I'm getting a
rather odd bounce message:

-----------------
Technical details of permanent failure:
Google tried to deliver your message, but it was rejected by the
server for the recipient domain faraday-tech.com by
mailhost1.faraday-tech.com. [210.59.249.140].

The error that the other server returned was:
553 5.1.3 <yhchen-w0jeGXs5+AWXmMXjJBpWqg@public.gmane.org>... Check FTC account failure!
-----------------

I've no idea what that means, other than the fix will probably have to
come from someone other than Yuan-Hsin...

Paul.
--

>
> Paul.
> --
>
>
>>
>> Paul.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-next" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html