From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 849641DD9D3; Tue, 10 Jun 2025 08:15:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749543312; cv=none; b=HfN+KJ0/5hkcGYQnAMFbNnzkSLFInMdGAzofP+rQI7VW+pgyC4lAG/rH2fSaE7VY1eTLJsDlPOpOyp/wTeA3rSkmnIKixOwOldC2W6Iwogcq2i/oRgeX53VZIrL/hLOaPSyHxTboiz8LOM/ueW4akMJmqYfUL6DOUePBcJzW/AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749543312; c=relaxed/simple; bh=bTz2jD+cGt2XQ/Ega0J5lq5VYe60lHLquMDkJ3TPTh4=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=dMX2fD1Fr7NsZl5aWQs4jsnkNgmuOS1nMVb356xBI62MrtkvAgJLf34qz13BNIwLcL4IfcPoKgbfWfYMhA4cxFRF0JAHfbQjizyH/D/865SV6KjVOnPgvBNdckzbJB8CqJsWULj+VSN2DO3XhSBVdoDueAofUoMgx6KVPAEMWq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CEGIj4mq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CEGIj4mq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD998C4CEEF; Tue, 10 Jun 2025 08:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749543312; bh=bTz2jD+cGt2XQ/Ega0J5lq5VYe60lHLquMDkJ3TPTh4=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=CEGIj4mq4tW1ToEzIVnsp8ZXU9S6QjDqYF2TM1c6YODY18mvNlszIZT8kNyWWwE1m wGLi/BlPKKYLqwP3hOHFZJOK68YZ+5G1ngd43RRKIKVrLEyKcPU92XUN6Tp2Hslz0d oYPPbjMzi1ivbh3FU96wxiFScZtGPCdk/YWvuZfpoDbyWgI9I14CAlpyklDiLQ7zSO epJvffFsRIZrl5cAtJ1Pwmebh/GubJK6ZAvqGL25lT+xuJjCTO9N30eHceAiOK/RKZ I7KAivRHbpt8wfKJ5uN8eaCsGdiYFSYrdNRrnd1YXxa8KV5VGJJpXlxi/vmPOa3uMx Om5JYKfu0osrw== Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Jun 2025 10:15:08 +0200 Message-Id: Cc: "Linux Kernel Mailing List" , "Linux Next Mailing List" Subject: Re: linux-next: build failure after merge of the rust-pin-init tree From: "Benno Lossin" To: "Stephen Rothwell" , "Miguel Ojeda" , "Andreas Hindborg" X-Mailer: aerc 0.20.1 References: <20250610142230.001af1d3@canb.auug.org.au> In-Reply-To: On Tue Jun 10, 2025 at 9:59 AM CEST, Benno Lossin wrote: > On Tue Jun 10, 2025 at 6:22 AM CEST, Stephen Rothwell wrote: >> Hi all, >> >> After merging the rust-pin-init tree, today's linux-next build (x86_64 >> allmodconfig) failed like this: >> >> error[E0282]: type annotations needed >> --> rust/kernel/configfs.rs:154:26 >> | >> 154 | subsystem <- pin_init::zeroed().chain( >> | ^^^^^^^^^^^^^^^^ cannot infer type of the= type parameter `T` declared on the function `zeroed` >> | >> help: consider specifying the generic argument >> | >> 154 | subsystem <- pin_init::zeroed::().chain( >> | +++++ >> >> error[E0282]: type annotations needed >> --> rust/kernel/configfs.rs:264:22 >> | >> 264 | group <- pin_init::zeroed().chain(|v: &mut Opaque| { >> | ^^^^^^^^^^^^^^^^ cannot infer type of the typ= e parameter `T` declared on the function `zeroed` >> | >> help: consider specifying the generic argument >> | >> 264 | group <- pin_init::zeroed::().chain(|v: &mut Opaque= | { >> | +++++ >> >> error: aborting due to 2 previous errors >> >> For more information about this error, try `rustc --explain E0282`. >> >> Caused by commit >> >> 0bcaea04244b ("rust: pin-init: rename `zeroed` to `init_zeroed`") >> >> I have used the rust-pin-init tree from next-20250606 for today. > > Thanks for catching this! I didn't test with `CONFIG_CONFIGFS=3Dy`, so th= e > code was cfg'd out... I'll add it to my tests. > > @Andreas I'll send a new version of the commit above with configfs > changed. (sorry forgot to add your emails and also some new info) Actually, the correct change would be this in commit 0bcaea04244b ("rust: pin-init: rename `zeroed` to `init_zeroed`"): diff --git a/rust/kernel/configfs.rs b/rust/kernel/configfs.rs index 34d0bea4f9a5..6d566a8bde74 100644 --- a/rust/kernel/configfs.rs +++ b/rust/kernel/configfs.rs @@ -151,7 +151,7 @@ pub fn new( data: impl PinInit, ) -> impl PinInit { try_pin_init!(Self { - subsystem <- pin_init::zeroed().chain( + subsystem <- pin_init::init_zeroed().chain( |place: &mut Opaque| { // SAFETY: We initialized the required fields of `plac= e.group` above. unsafe { @@ -261,7 +261,7 @@ pub fn new( data: impl PinInit, ) -> impl PinInit { try_pin_init!(Self { - group <- pin_init::zeroed().chain(|v: &mut Opaque| { + group <- pin_init::init_zeroed().chain(|v: &mut Opaque| { let place =3D v.get(); let name =3D name.as_bytes_with_nul().as_ptr(); // SAFETY: It is safe to initialize a group once it has be= en zeroed. @Miguel, @Andreas, how should I go about this? Send the commit above augmented with the diff, or send a patch with just the diff to the list? Or apply the diff directly to the commit in the pin-init-next branch & rebasing (potentially adding an Acked-by from Andreas)? Or some other way? --- Cheers, Benno