Re: [PATCH 1/3] drm/gem: Add callback for when handle count goes to 0

["Gary Guo" <gary@garyguo.net>]

On Sat Sep 5, 2026 at 11:25 PM BST, Klara Modin wrote:
> On 2026-09-05 11:31:41 +0200, Manuel Ebner wrote:
>> On Sat, 2026-09-05 at 07:36 +0200, Thorsten Leemhuis wrote:
>> > On 8/31/26 20:33, Alex Deucher wrote:
>> > > From: Mukul Joshi <mukul.joshi@amd.com>
>> > > ...
>> > ...
>> > 
>> > > > error[E0063]: missing field `handle_free` in initializer of `drm_gem_object_funcs`
>> > > >    --> rust/kernel/drm/gem/mod.rs:265:58
>> > > >     |
>> > > > 265 |     const OBJECT_FUNCS: bindings::drm_gem_object_funcs = bindings::drm_gem_object_funcs {
>> > > >     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `handle_free`
>> > > > 
>> > > > error: aborting due to 1 previous error
>> > > > 
>> > > > For more information about this error, try `rustc --explain E0063`.
>> > > > make[2]: *** [rust/Makefile:799: rust/kernel.o] Error 1
>> > > > make[1]: *** [/builddir/build/BUILD/kernel-7.3.0-build/kernel-next-20260904/linux-7.3.0-0.0.next.20260904.221.vanilla.fc43.aarch64/Makefile:1442: prepare] Error 2
>> > > > make: *** [Makefile:256: __sub-make] Error 2
>> > """
>> > Full log:
>> > https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-43-aarch64/10951622-next-next-all/builder-live.log.gz
>> > 
>> > Reverting this change and 2/3 from this set fixed the problem for me.
>
> That leaves only the documentation without the feature so might as well
> drop 3/3 too in that case?
>
> Otherwise, the following also fixes it for me:
>
> diff --git a/rust/kernel/drm/gem/mod.rs b/rust/kernel/drm/gem/mod.rs
> index e1ebad77ebe2..847e0ee38863 100644
> --- a/rust/kernel/drm/gem/mod.rs
> +++ b/rust/kernel/drm/gem/mod.rs
> @@ -278,6 +278,7 @@ impl<T: DriverObject, Ctx: DeviceContext> Object<T, Ctx> {
>          vm_ops: core::ptr::null_mut(),
>          evict: None,
>          rss: None,
> +        handle_free: None,

IMO this should use

    ..pin_init::zeroed()

to set all other fields as zero rather than explicitly listing all of them.

Best,
Gary

>      };
>  
>      /// Returns the `Device` that owns this GEM object.
>
>> 
>> Verified.
>> 
>> Thanks
>>  Manuel
>> > 
>> > Ciao, Thorsten
>> > > ...
>
> Regards,
> Klara Modin