From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: linux-next: kernel/trace/trace.c:658: error: Date: Thu, 23 Oct 2008 17:30:01 +0200 (CEST) Message-ID: References: <20081023213637.eff9b414.sfr@canb.auug.org.au> <20081023121145.GB27984@x200.localdomain> <49008D12.5090204@gmail.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463808415-835255333-1224775801=:18978" Return-path: Received: from nelson.telenet-ops.be ([195.130.133.66]:53761 "EHLO nelson.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbYJWPaE (ORCPT ); Thu, 23 Oct 2008 11:30:04 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: =?ISO-8859-1?Q?Fr=E9d=E9ric_Weisbecker?= Cc: Alexey Dobriyan , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463808415-835255333-1224775801=:18978 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 23 Oct 2008, Frédéric Weisbecker wrote: > 2008/10/23 Geert Uytterhoeven : > > If kernel/trace/trace.c calls irqs_disabled_flags(), it should include > > the include that defines irqs_disabled_flags(). You should not add it to > > some other random include. > > > > It's also happening on m68k: > > http://kisskb.ellerman.id.au/kisskb/buildresult/50641/ > > The fact is that other archs include this header into their > asm/system.h. It seems that's because > they need some non-traced irq_save/restore . > I wanted to stay in the same approach because future use of > raw_local_irq could be used elsewhere > and seem to work perfectly whithout adding special headers on most > arch. But there will be some > bug report for each future use of these functions for alpha.... (and > even m68k as it seems). > > What do you think? Should I let this patch as is or send a new one > (and one other for m68k). kernel/trace/trace.c needs to include at least , as that's where irqs_disabled_flags() is defined. If there are still other issues with the raw_local_irq(), IMHO they should be fixed separately. Hmm, what's this doing in : | #ifdef CONFIG_TRACE_IRQFLAGS_SUPPORT | ... | #endif /* CONFIG_X86 */ ^^^^^^^^^^ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ---1463808415-835255333-1224775801=:18978--