linux-next: Signed-off-by missing for commit in the rdma tree

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Hi all,

Commits

  cca19da0d998 ("RDMA/rxe: Remove unnecessary mr testing")
  90f0afc4039b ("RDMA/rxe: Handle remote errors in the midst of a Read reply sequence")
  aba632f6e406 ("RDMA/rxe: Make responder handle RDMA Read failures")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the rdma tree

[Jason Gunthorpe]

On Fri, Oct 28, 2022 at 06:33:28AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   cca19da0d998 ("RDMA/rxe: Remove unnecessary mr testing")
>   90f0afc4039b ("RDMA/rxe: Handle remote errors in the midst of a Read reply sequence")
>   aba632f6e406 ("RDMA/rxe: Make responder handle RDMA Read failures")
> 
> are missing a Signed-off-by from their committer.

I fixed it up, thanks

Jason

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

Hi all,

Commits

  71c082d70547 ("RDMA/bnxt_re: Remove unnecessary condition checks")
  d7fc2e1a321c ("RDMA/bnxt_re: Use firmware provided message timeout value")
  d1dde88622b9 ("RDMA/bnxt_re: Initialize fw with roce_mirror support")
  525b4368864c ("RDMA/bnxt_re: Add support for flow create/destroy")
  c23c893e3a02 ("RDMA/bnxt_re: Add support for mirror vnic")
  b8f4e7f1a275 ("RDMA/bnxt_re: Add support for unique GID")
  bebe1a1bb1cf ("RDMA/bnxt_re: Refactor stats context memory allocation")
  877d90abaa9e ("RDMA/bnxt_re: Refactor hw context memory allocation")
  a99b2425cc60 ("RDMA/bnxt_re: Add data structures for RoCE mirror support")
  47bd8cafcbf0 ("bnxt_en: Enhance stats context reservation logic")

are missing a Signed-off-by from their committers.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi all,

Commits

  185e34e8f249 ("RDMI: hfi1: drop cpumask_empty() call in hfi1/affinity.c")
  7c2c2f3a205b ("RDMA: hfi1: simplify hfi1_get_proc_affinity()")
  9370795029d4 ("RDMA: hfi1: use rounddown in find_hw_thread_mask()")
  9c965445a636 ("RDMA: hfi1: simplify init_real_cpu_mask()")
  f2c2afbba77c ("RDMA: hfi1: simplify find_hw_thread_mask()")
  37b3cba54b40 ("RDMA: hfi1: fix possible divide-by-zero in find_hw_thread_mask()")
  c15d5e70db96 ("cpumask: add cpumask_clear_cpus()")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

Hi all,

Commit

  a92fbeac7e94 ("RDMA/cache: Release GID table even if leak is detected")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the rdma tree

[Dennis Dalessandro]

On 4/8/2021 6:00 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>    042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
> 
> is missing a Signed-off-by from its author.

Doh! That's my fault. I must have fat fingered the delete button instead 
of editing the line when I was converting our email addresses to the new 
name.

Jason do you want a v2 of the patch?

-Denny

Re: linux-next: Signed-off-by missing for commit in the rdma tree

[Jason Gunthorpe]

On Fri, Apr 09, 2021 at 12:20:09PM -0400, Dennis Dalessandro wrote:
> On 4/8/2021 6:00 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commit
> > 
> >    042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
> > 
> > is missing a Signed-off-by from its author.
> 
> Doh! That's my fault. I must have fat fingered the delete button instead of
> editing the line when I was converting our email addresses to the new name.
> 
> Jason do you want a v2 of the patch?

It is a bit late at this point..

Jason

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hi all,

Commit

  5736c7c499f1 ("RDMA/rxe: Distinguish between down links and disabled links")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the rdma tree

[Stephen Rothwell]

Hi Doug,

Commit

  4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the rdma tree

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 455 bytes --]

On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
> Hi Doug,
> 
> Commit
> 
>   4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
> 
> is missing a Signed-off-by from its author.
> 

What's the best way to fix this?  I can rebase, but I know Linus hates
that.  What about git note?

-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: linux-next: Signed-off-by missing for commit in the rdma tree

[Linus Torvalds]

On Fri, Sep 1, 2017 at 5:06 AM, Doug Ledford <dledford@redhat.com> wrote:
> On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> Commit
>>
>>   4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>>
>> is missing a Signed-off-by from its author.
>>
>
> What's the best way to fix this?  I can rebase, but I know Linus hates
> that.  What about git note?

We don't end up using (or forwarding) git notes, so that won't help.

Generally, the answer to missing sign-offs is "don't do that again" if
it's not something major and there isn't a _pattern_ of it happening.

In this case, it's a one-liner patch from a developer who has lots of
other sign-offs, from a company that is very aware of his work and the
GPL, and an active contributor. so it's not like it has any legal
implications.

If it was some big important patch from a more questionable source,
and we'd be worried about covering the legal side, it would be a
different issue. As it is, it falls under "mistakes happen, not a big
deal, try to avoid it in the future".

If it *was* a bigger issue and you really want to make sure that the
chain is there for new contributors etc, rebasing to fix sign-offs
ends up being the best (still bad) solution.

                      Linus