From: Jason Gunthorpe <jgg@nvidia.com>
To: coverity-bot <keescook@chromium.org>
Cc: Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: Coverity: get_md_pagetable(): Control flow issues
Date: Wed, 2 Nov 2022 17:14:29 -0300 [thread overview]
Message-ID: <Y2LPpWrCK8rq0lIO@nvidia.com> (raw)
In-Reply-To: <202211021257.AF0B3BA7F@keescook>
On Wed, Nov 02, 2022 at 12:57:33PM -0700, coverity-bot wrote:
> /drivers/iommu/iommufd/selftest.c: 248 in get_md_pagetable()
> 242 IOMMUFD_OBJ_HW_PAGETABLE);
> 243 if (IS_ERR(obj))
> 244 return ERR_CAST(obj);
> 245 hwpt = container_of(obj, struct iommufd_hw_pagetable, obj);
> 246 if (hwpt->domain->ops != mock_ops.default_domain_ops) {
> 247 return ERR_PTR(-EINVAL);
> vvv CID 1527089: Control flow issues (UNREACHABLE)
> vvv This code cannot be reached: "iommufd_put_object(&hwpt->o...".
> 248 iommufd_put_object(&hwpt->obj);
> 249 }
> 250 *mock = container_of(hwpt->domain, struct mock_iommu_domain, domain);
> 251 return hwpt;
> 252 }
> 253
>
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
Yes, we already fixed this, thanks
Jason
prev parent reply other threads:[~2022-11-02 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 19:57 Coverity: get_md_pagetable(): Control flow issues coverity-bot
2022-11-02 20:14 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2LPpWrCK8rq0lIO@nvidia.com \
--to=jgg@nvidia.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox