* linux-next: Fixes tag needs some work in the erofs-fixes tree
@ 2022-11-07 20:34 Stephen Rothwell
2022-11-08 1:03 ` Gao Xiang
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2022-11-07 20:34 UTC (permalink / raw)
To: Gao Xiang; +Cc: Yue Hu, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 381 bytes --]
Hi all,
In commit
40f72c923c28 ("erofs: fix general protection fault when reading fragment")
Fixes tag
Fixes: 08a0c9ef3e7e ("erofs: support on-disk compressed fragments data")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: Fixes tag needs some work in the erofs-fixes tree
2022-11-07 20:34 linux-next: Fixes tag needs some work in the erofs-fixes tree Stephen Rothwell
@ 2022-11-08 1:03 ` Gao Xiang
0 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2022-11-08 1:03 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Gao Xiang, Yue Hu, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Stephen,
On Tue, Nov 08, 2022 at 07:34:59AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 40f72c923c28 ("erofs: fix general protection fault when reading fragment")
>
> Fixes tag
>
> Fixes: 08a0c9ef3e7e ("erofs: support on-disk compressed fragments data")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data")
>
Thanks for catching this. It seems it's wrong in the original patch,
let me correct this manually.
Thanks,
Gao Xiang
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: Fixes tag needs some work in the erofs-fixes tree
@ 2024-03-06 21:16 Stephen Rothwell
2024-03-07 9:17 ` Gao Xiang
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2024-03-06 21:16 UTC (permalink / raw)
To: Gao Xiang; +Cc: Jingbo Xu, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Hi all,
In commit
f531a3c17e7a ("erofs: apply proper VMA alignment for memory mapped files on THP")
Fixes tag
Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
So:
Fixes: be62c5198861 ("erofs: support large folios for fscache mode")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: linux-next: Fixes tag needs some work in the erofs-fixes tree
2024-03-06 21:16 Stephen Rothwell
@ 2024-03-07 9:17 ` Gao Xiang
0 siblings, 0 replies; 4+ messages in thread
From: Gao Xiang @ 2024-03-07 9:17 UTC (permalink / raw)
To: Stephen Rothwell, Gao Xiang
Cc: Jingbo Xu, Linux Kernel Mailing List, Linux Next Mailing List
Hi,
On 2024/3/7 05:16, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> f531a3c17e7a ("erofs: apply proper VMA alignment for memory mapped files on THP")
>
> Fixes tag
>
> Fixes: be62c5198861 ("erofs: enable large folios for fscache mode")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> So:
>
> Fixes: be62c5198861 ("erofs: support large folios for fscache mode")
Thanks for the reminder!
It seems that I quoted the wrong commit id and it should be
Fixes: e6687b89225e ("erofs: enable large folios for fscache mode")
I've fixed in the erofs-fixes tree.
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-07 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-07 20:34 linux-next: Fixes tag needs some work in the erofs-fixes tree Stephen Rothwell
2022-11-08 1:03 ` Gao Xiang
-- strict thread matches above, loose matches on Subject: below --
2024-03-06 21:16 Stephen Rothwell
2024-03-07 9:17 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox