From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nick Hainke <vincent@systemli.org>
Cc: linux-next@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: fix compiling when CONFIG_GPIO_CDEV_V1 is not defined
Date: Fri, 2 Dec 2022 16:30:33 +0200 [thread overview]
Message-ID: <Y4oMCYksMaQ6KYwU@smile.fi.intel.com> (raw)
In-Reply-To: <20221202140454.273333-1-vincent@systemli.org>
On Fri, Dec 02, 2022 at 03:04:54PM +0100, Nick Hainke wrote:
Thank you for the report!
I believe Bart needs to fold it into his patch / PR, because
it's not good to send a broken PR to Linus.
> If CONFIG_GPIO_CDEV_V1 is not defined compiling will fail with:
>
> drivers/gpio/gpiolib-cdev.c: In function 'linereq_ioctl':
> drivers/gpio/gpiolib-cdev.c:1468:16: error: implicit declaration of
> function 'call_ioctl_locked' [-Werror=implicit-function-declaration]
> 1468 | return call_ioctl_locked(file, cmd, arg, lr->gdev,
> | ^~~~~~~~~~~~~~~~~
> drivers/gpio/gpiolib-cdev.c: In function 'linereq_poll':
> drivers/gpio/gpiolib-cdev.c:1503:16: error: implicit declaration of
> function 'call_poll_locked'; did you mean 'wake_up_all_locked'?
> [-Werror=implicit-function-declaration]
> 1503 | return call_poll_locked(file, wait, lr->gdev,
> linereq_poll_unlocked);
> | ^~~~~~~~~~~~~~~~
> | wake_up_all_locked
> drivers/gpio/gpiolib-cdev.c: In function 'linereq_read':
> drivers/gpio/gpiolib-cdev.c:1566:16: error: implicit declaration of
> function 'call_read_locked'; did you mean 'xa_head_locked'?
> [-Werror=implicit-function-declaration]
> 1566 | return call_read_locked(file, buf, count, f_ps, lr->gdev,
> | ^~~~~~~~~~~~~~~~
> | xa_head_locked
Above is a bit too noisy for the commit message. It can be trimmed 3x times.
> Move "call_poll_locked", "call_ioctl_locked", "call_read_locked" and
> the necessary typedefs "poll_fn", "ioctl_fn", "read_fn" in front of the
> ifdef-statement checking CONFIG_GPIO_CDEV_V1.
> Fixes: 98d8b93c6171 ("gpiolib: protect the GPIO device against being dropped while in use by user-space")
>
> Signed-off-by: Nick Hainke <vincent@systemli.org>
Mustn't be blank line(s) in the tag block.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-02 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 14:04 [PATCH] gpiolib: fix compiling when CONFIG_GPIO_CDEV_V1 is not defined Nick Hainke
2022-12-02 14:30 ` Andy Shevchenko [this message]
2022-12-02 14:33 ` Andy Shevchenko
2022-12-02 14:48 ` Bartosz Golaszewski
2022-12-02 16:37 ` Nick
2022-12-02 14:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4oMCYksMaQ6KYwU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=vincent@systemli.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox