From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nick Hainke <vincent@systemli.org>
Cc: linux-next@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: fix compiling when CONFIG_GPIO_CDEV_V1 is not defined
Date: Fri, 2 Dec 2022 16:33:06 +0200 [thread overview]
Message-ID: <Y4oMolxWW7H15ayK@smile.fi.intel.com> (raw)
In-Reply-To: <Y4oMCYksMaQ6KYwU@smile.fi.intel.com>
On Fri, Dec 02, 2022 at 04:30:33PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 02, 2022 at 03:04:54PM +0100, Nick Hainke wrote:
...
> > drivers/gpio/gpiolib-cdev.c:1468:16: error: implicit declaration of
> > function 'call_ioctl_locked' [-Werror=implicit-function-declaration]
> > drivers/gpio/gpiolib-cdev.c:1503:16: error: implicit declaration of
> > function 'call_poll_locked'; did you mean 'wake_up_all_locked'?
> > [-Werror=implicit-function-declaration]
> > drivers/gpio/gpiolib-cdev.c:1566:16: error: implicit declaration of
> > function 'call_read_locked'; did you mean 'xa_head_locked'?
> > [-Werror=implicit-function-declaration]
> Above is a bit too noisy for the commit message. It can be trimmed 3x times.
To be precise leave only the above and make them as is (i.e. unwrapped even
if they are so long), because it's a citation from the compiler.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-02 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 14:04 [PATCH] gpiolib: fix compiling when CONFIG_GPIO_CDEV_V1 is not defined Nick Hainke
2022-12-02 14:30 ` Andy Shevchenko
2022-12-02 14:33 ` Andy Shevchenko [this message]
2022-12-02 14:48 ` Bartosz Golaszewski
2022-12-02 16:37 ` Nick
2022-12-02 14:55 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4oMolxWW7H15ayK@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=vincent@systemli.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox