From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C66C433DB for ; Mon, 15 Feb 2021 14:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 296E964E5A for ; Mon, 15 Feb 2021 14:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbhBOOfX (ORCPT ); Mon, 15 Feb 2021 09:35:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbhBOOfW (ORCPT ); Mon, 15 Feb 2021 09:35:22 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0964C061756; Mon, 15 Feb 2021 06:34:41 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lBewx-00EHAn-AI; Mon, 15 Feb 2021 14:34:07 +0000 Date: Mon, 15 Feb 2021 14:34:07 +0000 From: Al Viro To: Naresh Kamboju Cc: Arnd Bergmann , open list , Linux-Next Mailing List , LTP List , lkft-triage@lists.linaro.org, chrubis , Jan Stancek , Stephen Rothwell , Arnd Bergmann , "Eric W. Biederman" , Christian Brauner , Kees Cook , Peter Xu , Andrew Morton , Petr Vorel , Richard Palethorpe , Joerg.Vehlow@aox-tech.de Subject: Re: LTP: madvise08.c:203: TFAIL: No sequence in dump after MADV_DODUMP. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Feb 15, 2021 at 02:11:15PM +0530, Naresh Kamboju wrote: > fs/coredump.c:903:9: error: 'return' with a value, in function > returning void [-Werror=return-type] > 903 | return 0; > | ^ > > Build failed due to above error. FWIW, here the test results in Running tests....... <<>> tag=madvise08 stime=1613398818 cmdline="madvise08" contacts="" analysis=exit <<>> incrementing stop tst_test.c:1250: TINFO: Timeout per run is 0h 05m 00s madvise08.c:78: TINFO: Temporary core pattern is '/tmp/ltp-tgvQ3Lz1UZ/B6lwy6/dump-%p' madvise08.c:117: TINFO: Dump file should be dump-2276 madvise08.c:201: TPASS: madvise(..., MADV_DONTDUMP) madvise08.c:117: TINFO: Dump file should be dump-2277 madvise08.c:205: TPASS: madvise(..., MADV_DODUMP) Summary: passed 2 failed 0 skipped 0 warnings 0 <<>> initiation_status="ok" duration=0 termination_type=exited termination_id=0 corefile=no cutime=0 cstime=0 <<>> (built without -Werror=return-type, so I'd missed the warnings) Anyway, I've folded the fix (with those stray return 0 removed, of course) into #work.coredump and #for-next; works here. Could you test either branch (in git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git)?