From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 014EEC07E9B for ; Tue, 20 Jul 2021 12:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D906B6120E for ; Tue, 20 Jul 2021 12:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236193AbhGTLtm (ORCPT ); Tue, 20 Jul 2021 07:49:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237862AbhGTLsT (ORCPT ); Tue, 20 Jul 2021 07:48:19 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ED7AC0613DC for ; Tue, 20 Jul 2021 05:28:48 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id q18-20020a1ce9120000b02901f259f3a250so1945746wmc.2 for ; Tue, 20 Jul 2021 05:28:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HA5pgOt3LuB7s8wJqihPNWq2/H5z2E0M6pXYeU8VDyA=; b=bscvEdhIF7xDlYdr0m57loM89UGFczXij2tSGVhKyHrZMNESgX9PGh54fg9UWCChec bAAq+qyVyhvnkjaA8qCY6sgFOdfy91XgtKzzNtH5XG3w07hLbXgGULjzm+76kygiQ6G3 GEk8IMmKr2DimSath9SwgTbd+v/duPcMPMb8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HA5pgOt3LuB7s8wJqihPNWq2/H5z2E0M6pXYeU8VDyA=; b=oI7tjmJEIJs6HeRQw2Gy8Ar5dRPos91sRt0uPfjVoPhMA6dK+jBXBMNkeuZN7nNSmS U/28pzm29gg6YZtT8kZiP8HOm3m4xJgh8HCZwLGLvmVit9LifgPCvsn2jw5+DIzZCi3q 5zG9SXxJ/hVGjwZL+0FZIzPv9y9RTq3TRWqSX6aK54Y5E1K2WsK52+G2Zex2TNoQaxOq iSLHX+j8yAsyTTtra3QAZ/lZRJ36x+zBvPiNrSV1FwLE4lYYKlZF7ijUnQiW6y5Ptyr1 7vJU6eIi6/oG5JO3ujD6Crzfi7ejQB2Pa+WjaTmX6YLtrp/bvZqZXMLTNrcRDUmggXs0 YFYg== X-Gm-Message-State: AOAM5309jpJX/HnrbM6Slc5sDvVWnWLOZUHD0hP4DRTS1lNYWFs69qYX vXIO9x0kzrePS5p7CXLQwHr70w== X-Google-Smtp-Source: ABdhPJx99dLkVaK1o2AY7YxAZkKj20vHt6UA1LoL8K4PzW3OMhlMZXpAl7+fRffonLvUmQSAIdLiLg== X-Received: by 2002:a1c:628a:: with SMTP id w132mr4727263wmb.90.1626784126822; Tue, 20 Jul 2021 05:28:46 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:d571]) by smtp.gmail.com with ESMTPSA id 140sm19863114wmb.43.2021.07.20.05.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 05:28:46 -0700 (PDT) Date: Tue, 20 Jul 2021 13:28:45 +0100 From: Chris Down To: Naresh Kamboju Cc: Stephen Rothwell , Petr Mladek , Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: build failure after merge of the printk tree Message-ID: References: <20210720174300.018cc765@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1 (4b100969) (2021-06-12) Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hey folks, Naresh Kamboju writes: >On Tue, 20 Jul 2021 at 13:13, Stephen Rothwell wrote: >> >> Hi all, >> >> After merging the printk tree, today's linux-next build (mips allnoconfig) >> failed like this: >> >> arch/mips/kernel/genex.o: In function `handle_mcheck_int': >> (.text+0x190c): undefined reference to `printk' >> arch/mips/kernel/genex.o: In function `handle_reserved_int': >> (.text+0x1c8c): undefined reference to `printk' >> >> Caused by commit >> >> 337015573718 ("printk: Userspace format indexing support") > >Following MIPS builds failed at our end due the reported problem. Thanks: missed this as I made sure to change all .S files to use _printk, but this is in a .h file included in a .S file. Here's what's needed. :-) diff --git arch/mips/include/asm/asm.h arch/mips/include/asm/asm.h index ea4b62ece336..2f8ce94ebaaf 100644 --- arch/mips/include/asm/asm.h +++ arch/mips/include/asm/asm.h @@ -114,7 +114,7 @@ symbol = value .set push; \ .set reorder; \ PTR_LA a0, 8f; \ - jal printk; \ + jal _printk; \ .set pop; \ TEXT(string) #else