linux-next: Fixes tag needs some work in the cgroup tree

linux-next: Fixes tag needs some work in the cgroup tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

Hi all,

In commit

  a713af394cf3 ("cgroup: pids: use atomic64_t for pids->limit")

Fixes tag

  Fixes: commit 49b786ea146f ("cgroup: implement the PIDs subsystem")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the cgroup tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Hi all,

In commit

  2ca11b0e043b ("cgroup: Fix kernel-doc")

Fixes tag

  Fixes: 'commit e595cd706982 ("cgroup: track migration context in cgroup_mgctx")'

has these problem(s):

  - No SHA1 recognised

Please just use

git log -1 --format='Fixes: %h ("%s")' <commit>

so

Fixes: e595cd706982 ("cgroup: track migration context in cgroup_mgctx")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the cgroup tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hi all,

In commit

  f944e005aa9b ("cgroup/cpuset: Fix violation of cpuset locking rule")

Fixes tag

  Fixes: 4b842da276a8 ("cpuset: Make CPU hotplug work with partition)

has these problem(s):

  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cgroup tree

[Tejun Heo]

On Tue, Aug 10, 2021 at 08:51:46AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f944e005aa9b ("cgroup/cpuset: Fix violation of cpuset locking rule")
> 
> Fixes tag
> 
>   Fixes: 4b842da276a8 ("cpuset: Make CPU hotplug work with partition)
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes

Fixed. Thanks.

-- 
tejun

linux-next: Fixes tag needs some work in the cgroup tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

Hi all,

In commit

  6d73ba7928c0 ("sched/psi: Zero the memory of struct psi_group")

Fixes tag

  Fixes: commit 5f69a6577bc3 ("psi: dont alloc memory for psi by default")

has these problem(s):

  - leading word 'commit' unexpected.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cgroup tree

[Tejun Heo]

Hello, Stephen.

On Tue, Aug 16, 2022 at 08:32:38AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   6d73ba7928c0 ("sched/psi: Zero the memory of struct psi_group")
> 
> Fixes tag
> 
>   Fixes: commit 5f69a6577bc3 ("psi: dont alloc memory for psi by default")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected.

Oops, lemme fix up the tree.

Thanks.

-- 
tejun

linux-next: Fixes tag needs some work in the cgroup tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Hi all,

In commit

  169a8edf147f ("cgroup/cpuset: Move cpu.h include to cpuset-internal.h")

Fixes tag

  Fixes: dd46bd00ab4c ("cgroup/cpuset: move relax_domain_level to cpuset-v1.c")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 047b83097448 ("cgroup/cpuset: move relax_domain_level to cpuset-v1.c")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the cgroup tree

[Tejun Heo]

On Sun, Sep 01, 2024 at 08:52:13PM -0400, Waiman Long wrote:
> On 9/1/24 18:11, Stephen Rothwell wrote:
...
> Commit dd46bd00ab4c does exist in the cgroup tree, but it is missing Tejun's
> Signed-off. So it is probably in a dead branch. Commit 047b83097448 should

Hmm... I probably force pushed to fix up something?

> be the right hash for the for-6.12 branch. I don't know how I got the other
> commit hash though.
> 
> Tejun, could you update the commit hash in my patch?

Anyways, fixed up.

Thanks.

-- 
tejun