From: Jisheng Zhang <jszhang@kernel.org>
To: Suren Baghdasaryan <surenb@google.com>
Cc: sfr@canb.auug.org.au, akpm@linux-foundation.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH 1/1] sysctl: Fix 'one_thousand' defined but not used warning
Date: Sun, 23 Jan 2022 17:09:36 +0800 [thread overview]
Message-ID: <Ye0bUGBJWRp+abEF@xhacker> (raw)
In-Reply-To: <20220117012317.21168-1-surenb@google.com>
On Sun, Jan 16, 2022 at 05:23:17PM -0800, Suren Baghdasaryan wrote:
> Fix the following warning issued when CONFIG_PERF_EVENTS is not
> defined:
>
> kernel/sysctl.c:125:12: warning: 'one_thousand' defined but not used [-Wunused-variable]
>
> Fixes: 39c65a94cd96 ("mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Suren Baghdasaryan <surenb@google.com>
> ---
> kernel/sysctl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index ef77be575d87..81a6f2d47f77 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -122,7 +122,9 @@ static unsigned long one_ul = 1;
> static unsigned long long_max = LONG_MAX;
> static int one_hundred = 100;
> static int two_hundred = 200;
> +#ifdef CONFIG_PERF_EVENTS
> static int one_thousand = 1000;
what about moving one_thousand definition below to group it with
six_hundred_forty_kb var together, so that we can avoid one
#ifdef CONFIG_PERF_EVENTS ... #endif
> +#endif
> static int three_thousand = 3000;
> #ifdef CONFIG_PRINTK
> static int ten_thousand = 10000;
> --
> 2.34.1.703.g22d0c6ccf7-goog
>
next prev parent reply other threads:[~2022-01-23 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 1:23 [PATCH 1/1] sysctl: Fix 'one_thousand' defined but not used warning Suren Baghdasaryan
2022-01-23 9:09 ` Jisheng Zhang [this message]
2022-01-23 11:24 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ye0bUGBJWRp+abEF@xhacker \
--to=jszhang@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=surenb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).