From: Catalin Marinas <catalin.marinas@arm.com>
To: Liam Howlett <liam.howlett@oracle.com>
Cc: Will Deacon <will@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] arm64: Change elfcore for_each_mte_vma() to use VMA iterator
Date: Mon, 21 Feb 2022 18:06:50 +0000 [thread overview]
Message-ID: <YhPUuu+6TPMKjhwk@arm.com> (raw)
In-Reply-To: <20220218023650.672072-1-Liam.Howlett@oracle.com>
On Fri, Feb 18, 2022 at 02:37:04AM +0000, Liam Howlett wrote:
> diff --git a/arch/arm64/kernel/elfcore.c b/arch/arm64/kernel/elfcore.c
> index 3455ee4acc04..930a0bc4cac4 100644
> --- a/arch/arm64/kernel/elfcore.c
> +++ b/arch/arm64/kernel/elfcore.c
> @@ -8,9 +8,9 @@
> #include <asm/cpufeature.h>
> #include <asm/mte.h>
>
> -#define for_each_mte_vma(tsk, vma) \
> +#define for_each_mte_vma(vmi, vma) \
> if (system_supports_mte()) \
> - for (vma = tsk->mm->mmap; vma; vma = vma->vm_next) \
> + for_each_vma(vmi, vma) \
> if (vma->vm_flags & VM_MTE)
>
> static unsigned long mte_vma_tag_dump_size(struct vm_area_struct *vma)
> @@ -65,8 +65,9 @@ Elf_Half elf_core_extra_phdrs(void)
> {
> struct vm_area_struct *vma;
> int vma_count = 0;
> + VMA_ITERATOR(vmi, current->mm, 0);
>
> - for_each_mte_vma(current, vma)
> + for_each_mte_vma(vmi, vma)
> vma_count++;
I'm fine with the patch but it can't be applied to arm64 for-next/mte
branch as it won't build and the maple tree doesn't have the MTE
patches. Do you have a stable branch with the for_each_vma() iterator?
Anyway, if you find a way to solve the problem, for this patch:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2022-02-21 18:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 8:18 linux-next: build failure after merge of the maple tree Stephen Rothwell
2022-02-17 19:24 ` Will Deacon
2022-02-18 1:46 ` Liam Howlett
2022-02-18 2:37 ` [PATCH] arm64: Change elfcore for_each_mte_vma() to use VMA iterator Liam Howlett
2022-02-21 18:06 ` Catalin Marinas [this message]
2022-02-22 14:26 ` Liam Howlett
2022-02-22 16:20 ` Will Deacon
2022-02-22 17:26 ` Catalin Marinas
2022-02-22 18:54 ` Liam Howlett
2022-02-23 9:39 ` Catalin Marinas
2022-02-23 13:57 ` Liam Howlett
2022-02-23 11:37 ` Catalin Marinas
2022-02-23 14:11 ` Liam Howlett
2022-02-24 2:00 ` Liam Howlett
2022-02-25 15:50 ` Will Deacon
-- strict thread matches above, loose matches on Subject: below --
2022-02-23 2:32 linux-next: build failure after merge of the maple tree Liam Howlett
2022-02-23 12:47 ` [PATCH] arm64: Change elfcore for_each_mte_vma() to use VMA iterator kernel test robot
2022-02-23 13:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhPUuu+6TPMKjhwk@arm.com \
--to=catalin.marinas@arm.com \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).