From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACEC4C433F5 for ; Mon, 21 Mar 2022 14:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346347AbiCUO3D (ORCPT ); Mon, 21 Mar 2022 10:29:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349182AbiCUO1S (ORCPT ); Mon, 21 Mar 2022 10:27:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8DB8D60FC; Mon, 21 Mar 2022 07:20:02 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A2F01042; Mon, 21 Mar 2022 07:20:01 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.92.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D798F3F73D; Mon, 21 Mar 2022 07:19:58 -0700 (PDT) Date: Mon, 21 Mar 2022 14:19:53 +0000 From: Mark Rutland To: Peter Zijlstra Cc: Stephen Rothwell , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List , Linux Next Mailing List , mhiramat@kernel.org, rostedt@goodmis.org, ast@kernel.org, hjl.tools@gmail.com, rick.p.edgecombe@intel.com, rppt@kernel.org, linux-toolchains@vger.kernel.org, Andrew.Cooper3@citrix.com, ndesaulniers@google.com Subject: Re: linux-next: build warnings after merge of the tip tree Message-ID: References: <20220321140327.777f9554@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Mar 21, 2022 at 02:45:16PM +0100, Peter Zijlstra wrote: > On Mon, Mar 21, 2022 at 02:08:23PM +0100, Peter Zijlstra wrote: > > On Mon, Mar 21, 2022 at 02:04:05PM +0100, Peter Zijlstra wrote: > > > On Mon, Mar 21, 2022 at 01:55:49PM +0100, Peter Zijlstra wrote: > > > > On Mon, Mar 21, 2022 at 02:03:27PM +1100, Stephen Rothwell wrote: > > > > > Hi all, > > > > > > > > > > After merging the tip tree, today's linux-next build (x864 allmodconfig) > > > > > produced these new warnings: > > > > > > > > > > vmlinux.o: warning: objtool: arch_rethook_prepare()+0x55: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: arch_rethook_trampoline_callback()+0x3e: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x93e: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x5f2: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: unwind_next_frame()+0x4a7: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: __rethook_find_ret_addr()+0x81: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: __rethook_find_ret_addr()+0x90: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: rethook_trampoline_handler()+0x8c: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > vmlinux.o: warning: objtool: rethook_trampoline_handler()+0x9b: relocation to !ENDBR: arch_rethook_trampoline+0x0 > > > > > > > > Hurmph, lemme go figure out where that code comes from, I've not seen > > > > those. > > > > > > Ahh, something tracing. I'll go do some patches on top of it. > > > > Also, that x86 patch has never his x86@kernel.org and doesn't have an > > ACK from any x86 person :-((( > > Worse, it adds a 3rd return trampoline without replacing any of the > existing two :-( Likewise; I have the same complaints for the arm64 patch. I haven't had the chance to review/ack that, and I'm actively working on improving out unwinder and the way it interacts with the various *existing* trampolines, so adding yat another is *not* good. > Why was this merged? Likewise, same question for arm64? Thanks, Mark.