From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F99C433F5 for ; Mon, 2 May 2022 17:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1386655AbiEBRg2 (ORCPT ); Mon, 2 May 2022 13:36:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241242AbiEBRg1 (ORCPT ); Mon, 2 May 2022 13:36:27 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BD4525DE; Mon, 2 May 2022 10:32:58 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D072E5C00A4; Mon, 2 May 2022 13:32:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 02 May 2022 13:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651512775; x=1651599175; bh=O38fQ+vhsG 3gGTdn+UJjK1HqNAThZrZHdOVpoaDuDIc=; b=MfRDZYe8MasDLw7mnSR0nMcXO6 4/BCqUrbkFqYZBEg0l+kIuUu6oDux71JQEo4L3/7mxaUcoK9AFLnkicX5gwhdHWN jBxjAWO3MdnwOVQ4ez83ZxnoyOWmbSp3YHhyqleeDE+HBesK93l7m5KUTujlaJ8s 0PfRo43FJ5WOdd31QrOF/H5kAAr1twj/vgproC2yiRYRGE/Ps1kgFFmTd/pXRfzq SjRGwbqxkBL4PpMVh+fKGoFh4FytcqeAv/9sbZ1uW7rO+2+vt6/PULnkpeLPP9x9 LKs3sNjOxlENZiGVC6uRyUrH7ww1I2j+NxJC0BAW5qRnjCwxSdv3/OqZy9mA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651512775; x= 1651599175; bh=O38fQ+vhsG3gGTdn+UJjK1HqNAThZrZHdOVpoaDuDIc=; b=E NFahZAk5ymZsCbb2bg/Gia3AhsCEykD3oglo8tKhbCiyBDXqLGzlxuhGI01p+To5 xGR77tObewUcCG1ALI5rvG54B/1fmHLfECDhSGCvgYxovwQVDBLlBXXRHutaex9C Buo7PTm/0Fs+wPvPzrxTSfuCqr/RgtbVqKsxgvfTAYcWcfCb5rFzY39I4bCYR/vg 4mDbX9Dqj4F7zO63SFgbu7DIV0eWuT88dmqa5aadVsIOp2mofsdrc8U69OufaHIE ta8fV8z06i0MxmsYBU+0llN98//hGRCrBQqQq/zQkQFWTY35/TefXboiOnkqwUmk GbTlug8kJY/sjPd7XT2bg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepheegvd evvdeljeeugfdtudduhfekledtiefhveejkeejuefhtdeufefhgfehkeetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 May 2022 13:32:55 -0400 (EDT) Date: Mon, 2 May 2022 19:32:54 +0200 From: Greg KH To: Matthias Kaehlcke Cc: Stephen Rothwell , Ravi Chandra Sadineni , Linux Kernel Mailing List , Linux Next Mailing List , Douglas Anderson Subject: Re: linux-next: build failure after merge of the usb tree Message-ID: References: <20220502210728.0b36f3cd@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, May 02, 2022 at 10:09:25AM -0700, Matthias Kaehlcke wrote: > On Mon, May 02, 2022 at 01:40:45PM +0200, Greg KH wrote: > > On Mon, May 02, 2022 at 09:07:28PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the usb tree, today's linux-next build (x86_64 > > > modules_install) failed like this: > > > > > > depmod: ERROR: Cycle detected: usbcore -> onboard_usb_hub -> usbcore > > > depmod: ERROR: Found 2 modules in dependency cycles! > > > > > > Caused by commit > > > > > > c40b62216c1a ("usb: core: hcd: Create platform devices for onboard hubs in probe()") > > > > > > I have reverted that commit for today. > > > > argh, I thought the build issues were fixed :( > > Sorry about that :( > > The *build* issues were actually fixed, however I did not try > modules_install ... > > > I'll go revert that series from my tree later today, thanks for the > > report. > > I think the dependency situation can only be resolved by linking > onboard_hub_create/destroy_pdevs() into the USB core module. My initial > idea was to build them into the kernel binary, however that doesn't > work because onboard_hub_create_pdevs() calls usb_of_get_device_node(), > which is part of the core module when CONFIG_USB=m. The two function > are relatively lightweight and don't depend on internals of the > onboard_usb_hub driver (besides the device id table) so linking them > into the core module doesn't seem too ugly. I'll try to look at this next week, it shouldn't be that complex. If it is, something feels wrong... thanks, greg k-h