linux-next: build warning after merge of the tpmdd tree

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_of.c: In function 'read_log_of':
drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
  sizep = of_get_property(np, "linux,sml-size", NULL);
        ^

Introduced by commit

  4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")

This commit is just wrong :-(

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

On Tue, Nov 15, 2016 at 12:01:07PM +1100, Stephen Rothwell wrote:
> Hi Jarkko,
> 
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/char/tpm/tpm_of.c: In function 'read_log_of':
> drivers/char/tpm/tpm_of.c:37:8: warning: 'np' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   sizep = of_get_property(np, "linux,sml-size", NULL);
>         ^
> 
> Introduced by commit
> 
>   4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node property")
> 
> This commit is just wrong :-(

It really is. I'll drop it from my tree.

> -- 
> Cheers,
> Stephen Rothwell

/Jarkko

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  rc = tpm_tis_send_data(chip, cmd_getticks, len);
                               ^
drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
 static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
            ^
drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  rc = tpm_tis_send_data(chip, cmd_getticks, len);
                               ^
drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
 static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
            ^

Introduced by commit

  5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the tpmdd tree

[Colin Ian King]

Thanks for reporting that Stephen, I've sent a fix to address this issue.

Colin

On 07/09/17 03:31, Stephen Rothwell wrote:
> Hi Jarkko,
> 
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   rc = tpm_tis_send_data(chip, cmd_getticks, len);
>                                ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
>  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
>             ^
> drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>   rc = tpm_tis_send_data(chip, cmd_getticks, len);
>                                ^
> drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
>  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
>             ^
> 
> Introduced by commit
> 
>   5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> 

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

Colin, Stephen,

Thank you. I'll apply Colin's fix.

/Jarkko

On Thu, Sep 07, 2017 at 09:43:37AM +0100, Colin Ian King wrote:
> Thanks for reporting that Stephen, I've sent a fix to address this issue.
> 
> Colin
> 
> On 07/09/17 03:31, Stephen Rothwell wrote:
> > Hi Jarkko,
> > 
> > After merging the tpmdd tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > drivers/char/tpm/tpm_tis_core.c: In function 'probe_itpm':
> > drivers/char/tpm/tpm_tis_core.c:469:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   rc = tpm_tis_send_data(chip, cmd_getticks, len);
> >                                ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> >  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> >             ^
> > drivers/char/tpm/tpm_tis_core.c:477:31: warning: passing argument 2 of 'tpm_tis_send_data' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
> >   rc = tpm_tis_send_data(chip, cmd_getticks, len);
> >                                ^
> > drivers/char/tpm/tpm_tis_core.c:255:12: note: expected 'u8 * {aka unsigned char *}' but argument is of type 'const u8 * {aka const unsigned char *}'
> >  static int tpm_tis_send_data(struct tpm_chip *chip, u8 *buf, size_t len)
> >             ^
> > 
> > Introduced by commit
> > 
> >   5e35bd8e06b9 ("tpm_tis: make array cmd_getticks static const to shink object code size")
> > 
> 

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-Wunused-variable]
  struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
                       ^
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-Wunused-variable]
  struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
                       ^

Introduced by commit

  6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")

-- 
Cheers,
Stephen Rothwell

RE: linux-next: build warning after merge of the tpmdd tree

[Shaikh, Azhar]

Hi Stephen,

Thanks for reporting this.

I have uploaded new patchset to tpmdd mailing list.

Regards,
Azhar Shaikh

>-----Original Message-----
>From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
>Sent: Monday, January 1, 2018 6:51 PM
>To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
>List <linux-kernel@vger.kernel.org>; Shaikh, Azhar <azhar.shaikh@intel.com>
>Subject: linux-next: build warning after merge of the tpmdd tree
>
>Hi Jarkko,
>
>After merging the tpmdd tree, today's linux-next build (x86_64
>allmodconfig) produced this warning:
>
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
>drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-
>Wunused-variable]
>  struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
>                       ^
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
>drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-
>Wunused-variable]
>  struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
>                       ^
>
>Introduced by commit
>
>  6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()")
>
>--
>Cheers,
>Stephen Rothwell

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2295 bytes --]

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
 #define TPM_RETRY      5
 
In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
 #define TPM_RETRY  50
 
drivers/char/tpm/tpm_i2c_infineon.c:30: warning: "TPM_BUFSIZE" redefined
 #define TPM_BUFSIZE 1260
 
In file included from drivers/char/tpm/tpm_i2c_infineon.c:27:
drivers/char/tpm/tpm.h:41: note: this is the location of the previous definition
 #define TPM_BUFSIZE  4096
 
In file included from drivers/char/tpm/st33zp24/i2c.c:30:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
 #define TPM_BUFSIZE                     2048
 
In file included from drivers/char/tpm/st33zp24/i2c.c:29:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
 #define TPM_BUFSIZE  4096
 
In file included from drivers/char/tpm/st33zp24/spi.c:30:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
 #define TPM_BUFSIZE                     2048
 
In file included from drivers/char/tpm/st33zp24/spi.c:29:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
 #define TPM_BUFSIZE  4096
 
In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
 #define TPM_BUFSIZE                     2048
 
In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
 #define TPM_BUFSIZE  4096
 
In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
 #define TPM_BUFSIZE                     2048
 
In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
 #define TPM_BUFSIZE  4096
 

Introduced by commit

  569c1057f9ac ("tpm: move tpm_chip definition to include/linux/tpm.h")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

On Thu, Feb 07, 2019 at 01:47:33PM +1100, Stephen Rothwell wrote:
> Hi Jarkko,
> 
> After merging the tpmdd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/char/tpm/tpm_i2c_nuvoton.c:45: warning: "TPM_RETRY" redefined
>  #define TPM_RETRY      5
>  
> In file included from drivers/char/tpm/tpm_i2c_nuvoton.c:35:
> drivers/char/tpm/tpm.h:43: note: this is the location of the previous definition
>  #define TPM_RETRY  50
>  
> drivers/char/tpm/tpm_i2c_infineon.c:30: warning: "TPM_BUFSIZE" redefined
>  #define TPM_BUFSIZE 1260
>  
> In file included from drivers/char/tpm/tpm_i2c_infineon.c:27:
> drivers/char/tpm/tpm.h:41: note: this is the location of the previous definition
>  #define TPM_BUFSIZE  4096
>  
> In file included from drivers/char/tpm/st33zp24/i2c.c:30:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
>  #define TPM_BUFSIZE                     2048
>  
> In file included from drivers/char/tpm/st33zp24/i2c.c:29:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
>  #define TPM_BUFSIZE  4096
>  
> In file included from drivers/char/tpm/st33zp24/spi.c:30:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
>  #define TPM_BUFSIZE                     2048
>  
> In file included from drivers/char/tpm/st33zp24/spi.c:29:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
>  #define TPM_BUFSIZE  4096
>  
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
>  #define TPM_BUFSIZE                     2048
>  
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
>  #define TPM_BUFSIZE  4096
>  
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:34:
> drivers/char/tpm/st33zp24/st33zp24.h:22: warning: "TPM_BUFSIZE" redefined
>  #define TPM_BUFSIZE                     2048
>  
> In file included from drivers/char/tpm/st33zp24/st33zp24.c:33:
> drivers/char/tpm/st33zp24/../tpm.h:41: note: this is the location of the previous definition
>  #define TPM_BUFSIZE  4096
>  
> 
> Introduced by commit
> 
>   569c1057f9ac ("tpm: move tpm_chip definition to include/linux/tpm.h")

Hi I forgot apply this before that commit:

tpm: Fix some name collisions with drivers/char/tpm.h

* Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to
  ST33ZP24_BUFSIZE.
* Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to
  TPM_I2C_INFINEON_BUFSIZE.
* Rename TPM_RETRY in tpm_i2c_nuvoton to TPM_I2C_RETRIES.
* Remove TPM_HEADER_SIZE from tpm_i2c_nuvoton.

Cc: stable@vger.kernel.org
Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)")
Fixes: aad628c1d91a ("char/tpm: Add new driver for Infineon I2C TIS TPM")
Fixes: 32d33b29ba07 ("TPM: Retry SaveState command in suspend path")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

It is now pushed.

/Jarkko

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

Hi all,

After merging the tpmdd tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

drivers/firmware/efi/tpm.c: In function 'efi_tpm_eventlog_init':
drivers/firmware/efi/tpm.c:80:10: warning: passing argument 1 of 'tpm2_calc_event_log_size' makes pointer from integer without a cast [-Wint-conversion]
  tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log
                                      ~~~~~~~~~~~~~~~~~
          + sizeof(final_tbl->version)
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          + sizeof(final_tbl->nr_events),
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/firmware/efi/tpm.c:19:43: note: expected 'void *' but argument is of type 'long unsigned int'
 static int tpm2_calc_event_log_size(void *data, int count, void *size_info)
                                     ~~~~~~^~~~

Introduced by commit

  a537b15c54a3 ("tpm: Reserve the TPM final events table")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

Matthew, can you provide a fixup for this?

/Jarkko

On Tue, Jun 11, 2019 at 02:52:55PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tpmdd tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> drivers/firmware/efi/tpm.c: In function 'efi_tpm_eventlog_init':
> drivers/firmware/efi/tpm.c:80:10: warning: passing argument 1 of 'tpm2_calc_event_log_size' makes pointer from integer without a cast [-Wint-conversion]
>   tbl_size = tpm2_calc_event_log_size(efi.tpm_final_log
>                                       ~~~~~~~~~~~~~~~~~
>           + sizeof(final_tbl->version)
>           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>           + sizeof(final_tbl->nr_events),
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/firmware/efi/tpm.c:19:43: note: expected 'void *' but argument is of type 'long unsigned int'
>  static int tpm2_calc_event_log_size(void *data, int count, void *size_info)
>                                      ~~~~~~^~~~
> 
> Introduced by commit
> 
>   a537b15c54a3 ("tpm: Reserve the TPM final events table")
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

Hi all,

After merging the tpmdd tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/security/tpm/tpm-security.rst: WARNING: document isn't included in any toctree

Introduced by commit

  ddfb3687c538 ("Documentation: add tpm-security.rst")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tpmdd tree

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

On Mon, May 06, 2024 at 04:21:05PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tpmdd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/security/tpm/tpm-security.rst: WARNING: document isn't included in any toctree
> 
> Introduced by commit
> 
>   ddfb3687c538 ("Documentation: add tpm-security.rst")
> 

Duh! I should have added the toctree for that doc when reviewing it. I will be
sending the fixup shortly.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the tpmdd tree

[Bagas Sanjaya]

On 5/6/24 17:48, Bagas Sanjaya wrote:
> On Mon, May 06, 2024 at 04:21:05PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the tpmdd tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/security/tpm/tpm-security.rst: WARNING: document isn't included in any toctree
>>
>> Introduced by commit
>>
>>   ddfb3687c538 ("Documentation: add tpm-security.rst")
>>
> 
> Duh! I should have added the toctree for that doc when reviewing it. I will be
> sending the fixup shortly.
> 

Oops, I feel like had not reviewed that doc.

Sorry for inconvenience.

-- 
An old man doll... just what I always wanted! - Clara

linux-next: build warning after merge of the tpmdd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi all,

After merging the tpmdd tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/security/tpm/tpm_ffa_crb.rst: WARNING: document isn't included in any toctree

Introduced by commit

  115be78c0bfe ("Documentation: tpm: add documentation for the CRB FF-A interface")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

On Tue, Mar 11, 2025 at 09:00:11PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tpmdd tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/security/tpm/tpm_ffa_crb.rst: WARNING: document isn't included in any toctree
> 
> Introduced by commit
> 
>   115be78c0bfe ("Documentation: tpm: add documentation for the CRB FF-A interface")
> 
> -- 
> Cheers,
> Stephen Rothwell

Stuart, could you send a replacement patch and I'll repeal and replace?

BR, Jarkko

Re: linux-next: build warning after merge of the tpmdd tree

[Stuart Yoder]

On 3/11/25 5:10 AM, Jarkko Sakkinen wrote:
> On Tue, Mar 11, 2025 at 09:00:11PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the tpmdd tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/security/tpm/tpm_ffa_crb.rst: WARNING: document isn't included in any toctree
>>
>> Introduced by commit
>>
>>    115be78c0bfe ("Documentation: tpm: add documentation for the CRB FF-A interface")
>>
>> -- 
>> Cheers,
>> Stephen Rothwell
> 
> Stuart, could you send a replacement patch and I'll repeal and replace?

Replacement patch is set.  I just sent v7 patch 5/5.  If you need me to
resend the entire series as v7 I'll do that.

Thanks!
Stuart

Re: linux-next: build warning after merge of the tpmdd tree

[Jarkko Sakkinen]

On Tue, Mar 11, 2025 at 09:21:49AM -0500, Stuart Yoder wrote:
> 
> 
> On 3/11/25 5:10 AM, Jarkko Sakkinen wrote:
> > On Tue, Mar 11, 2025 at 09:00:11PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the tpmdd tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > > 
> > > Documentation/security/tpm/tpm_ffa_crb.rst: WARNING: document isn't included in any toctree
> > > 
> > > Introduced by commit
> > > 
> > >    115be78c0bfe ("Documentation: tpm: add documentation for the CRB FF-A interface")
> > > 
> > > -- 
> > > Cheers,
> > > Stephen Rothwell
> > 
> > Stuart, could you send a replacement patch and I'll repeal and replace?
> 
> Replacement patch is set.  I just sent v7 patch 5/5.  If you need me to
> resend the entire series as v7 I'll do that.

Yeah, so the build issue needs to be sorted. Also Sudeep's request on
ACPICA feedback was legit. No worries but I'd feel that it'd be the
safest call to postpone to 6.16 and get a bit more feedback before
moving forward.

> 
> Thanks!
> Stuart

BR, Jarkko