linux-next: build warnings after merge of the iommufd tree

linux-next: build warnings after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced these warnings:

drivers/iommu/iommufd/device.c:1: warning: no structured comments found
drivers/iommu/iommufd/main.c:1: warning: no structured comments found

Introduced by commit

  f3873afb9d7e ("iommufd: Document overview of iommufd")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the iommufd tree

[Jason Gunthorpe]

On Thu, Nov 10, 2022 at 06:29:38PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> drivers/iommu/iommufd/device.c:1: warning: no structured comments found
> drivers/iommu/iommufd/main.c:1: warning: no structured comments found

This fix was waiting an ack before I could include it.

All is sorted out now, thanks

Jason

linux-next: build warnings after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced these warnings:

include/uapi/linux/iommufd.h:433: warning: expecting prototype for enum iommufd_hw_info_capabilities. Prototype was for enum iommufd_hw_capabilities instead
include/uapi/linux/iommufd.h:497: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_set_dirty_tracking'
include/uapi/linux/iommufd.h:512: warning: expecting prototype for enum iommufd_get_dirty_bitmap_flags. Prototype was for enum iommufd_hwpt_get_dirty_bitmap_flags instead
include/uapi/linux/iommufd.h:542: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_get_dirty_bitmap'

Introduced by commits

  f87900f25050 ("iommufd: Add a flag to skip clearing of IOPTE dirty")
  d2b3a545cdcc ("iommufd: Add capabilities to IOMMU_GET_HW_INFO")
  1337d793ea25 ("iommufd: Add IOMMU_HWPT_GET_DIRTY_BITMAP")
  ccccda6d18bd ("iommufd: Add IOMMU_HWPT_SET_DIRTY_TRACKING")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the iommufd tree

[Joao Martins]

On 23/10/2023 06:47, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> include/uapi/linux/iommufd.h:433: warning: expecting prototype for enum iommufd_hw_info_capabilities. Prototype was for enum iommufd_hw_capabilities instead
> include/uapi/linux/iommufd.h:497: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_set_dirty_tracking'
> include/uapi/linux/iommufd.h:512: warning: expecting prototype for enum iommufd_get_dirty_bitmap_flags. Prototype was for enum iommufd_hwpt_get_dirty_bitmap_flags instead
> include/uapi/linux/iommufd.h:542: warning: Function parameter or member '__reserved' not described in 'iommu_hwpt_get_dirty_bitmap'
> 
Thanks

I've fixed these warnings in the offending patches below; for the next version.

> Introduced by commits
> 
>   f87900f25050 ("iommufd: Add a flag to skip clearing of IOPTE dirty")
>   d2b3a545cdcc ("iommufd: Add capabilities to IOMMU_GET_HW_INFO")
>   1337d793ea25 ("iommufd: Add IOMMU_HWPT_GET_DIRTY_BITMAP")
>   ccccda6d18bd ("iommufd: Add IOMMU_HWPT_SET_DIRTY_TRACKING")
> 

linux-next: build warnings after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced these warnings:

include/uapi/linux/iommufd.h:1024: warning: Enum value 'IOMMU_VEVENTQ_FLAG_LOST_EVENTS' not described in enum 'iommu_veventq_flag'
include/uapi/linux/iommufd.h:1024: warning: Excess enum value 'IOMMU_VEVENTQ_FLAG_OVERFLOW' description in 'iommu_veventq_flag'
include/uapi/linux/iommufd.h:1120: warning: Function parameter or struct member 'viommu_id' not described in 'iommu_veventq_alloc'
include/uapi/linux/iommufd.h:1120: warning: Excess struct member 'viommu' description in 'iommu_veventq_alloc'

Introduced by commit

  50c842dd6cd3 ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warnings after merge of the iommufd tree

[Nicolin Chen]

On Tue, Mar 18, 2025 at 09:45:34PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the iommufd tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> include/uapi/linux/iommufd.h:1024: warning: Enum value 'IOMMU_VEVENTQ_FLAG_LOST_EVENTS' not described in enum 'iommu_veventq_flag'
> include/uapi/linux/iommufd.h:1024: warning: Excess enum value 'IOMMU_VEVENTQ_FLAG_OVERFLOW' description in 'iommu_veventq_flag'
> include/uapi/linux/iommufd.h:1120: warning: Function parameter or struct member 'viommu_id' not described in 'iommu_veventq_alloc'
> include/uapi/linux/iommufd.h:1120: warning: Excess struct member 'viommu' description in 'iommu_veventq_alloc'
> 
> Introduced by commit
> 
>   50c842dd6cd3 ("iommufd: Add IOMMUFD_OBJ_VEVENTQ and IOMMUFD_CMD_VEVENTQ_ALLOC")

Sent a fix:
https://lore.kernel.org/linux-iommu/20250318163022.709490-1-nicolinc@nvidia.com/

Thanks!
Nicolin

linux-next: build warnings after merge of the iommufd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

Hi all,

After merging the iommufd tree, today's linux-next build (htmldocs)
produced these warnings:

Documentation/userspace-api/iommufd:335: include/uapi/linux/iommufd.h:456: ERROR: Unexpected indentation. [docutils]
Documentation/userspace-api/iommufd:335: include/uapi/linux/iommufd.h:457: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]

Introduced by commit

  9f0b286fe401 ("iommu/arm-smmu-v3-iommufd: Allow attaching nested domain for GBPA cases")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]